Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets


--- David Miller <davem@xxxxxxxxxxxxx> wrote:

From: Nagendra Tomar <tomer_iisc@xxxxxxxxx>
Date: Wed, 19 Sep 2007 15:55:58 -0700 (PDT)

I agree that setting SOCK_NOSPACE would have been a more elegant
fix. Infact I thought a lot about that before deciding on this fix.

I guess this means you also noticed that you are removing
the one and only test of this bit too?

You can't remove this, it's critical for performance.

I'm sure you would have seen value in the check that's why the
check is there.

Now we have two critical points to discuss

1. How can we achieve the ET EPOLLOUT event with the SOCK_NOSPACE
check in place ?
2. How much effect will removing the check have (if we cannot
find a way to get the ET EPOLLOUT notification w/ the check
in place) ?

Regding (2), IMHO for a "fast sender" the SOCK_NOSPACE check will
almost always pass as the sender will come back to write (or poll)
before the prev data is drained out. If he doesn't do that, he is
not a "fast sender" by definition". A "fast sender" should always
have some data to send when he practically (per the sndbuf space)
can.

For a "slow sender", do we really care abt the optimization ?

Thanx,
Tomar



___________________________________________________________
Yahoo! Answers - Got a question? Someone out there knows the answer. Try it
now.
http://uk.answers.yahoo.com/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Removing .tmp_versions considered harmful
    ... as MadWifi) are now compiled with spurious warnings about unresolved ... to fix all that mess. ... I'm aware that 2-4 support complicates things a little but if people ... Can we settle on removing only *.mod files ...
    (Linux-Kernel)
  • Re: [PATCH] mm/filemap.c: unconditionally call mark_page_accessed
    ... Andrea Arcangeli wrote: ... I still think the simple fix of removing the ... in>=PAGE_SIZE chunks. ...
    (Linux-Kernel)
  • Re: power point & mpegs
    ... Yeah you have some Movie Software like Muvee autoproducer or something on ... The easiest way to fix the problem is by removing the software...if you dont ... These are the mainconcept mpeg filters/decoders which are installed by Muvee ...
    (microsoft.public.powerpoint)
  • Re: [PATCH] mm/filemap.c: unconditionally call mark_page_accessed
    ... I still think the simple fix of removing the ... the problem of falsely activating pages when the file is read in small ... in>=PAGE_SIZE chunks. ...
    (Linux-Kernel)
  • RE: PrivilegeNotHeld, .Net 1.1 sp1 bug, hotfix
    ... private void button1_Click(object sender, System.EventArgs e) ... FIX: A security token leak occurs when you use the System.Management ... namespace and you set the ConnectionOptions.EnablePrivileges property to ...
    (microsoft.public.dotnet.framework)