Re: [PATCH] kernel/printk.c: Concerns about the console handover



On Fri, Sep 21, 2007 at 02:36:50PM +0100, Maciej W. Rozycki wrote:
On Fri, 21 Sep 2007, Andrew Morton wrote:

It would be useful to have some basic information like: Which kernel
version was this found in? Which kernel version last worked?

The kernel used was a 2.6.23-rc5 snapshot from Sep 4th, 2007 taken from
the linux-mips.org tree (as stated by the revision of the patch provided).
There is no version that can be considered working as the change to add
the printk() to register_console() went in before drivers/serial/zs.c was
added and the old drivers/tc/zs.c driver might have been to sloppy to
handle such bits as the transmitter enable properly. I may investigate.

Chances are nobody tried any version of the kernel from the period
between the printk() was added and drivers/tc/zs.c removed with the
DECstation; I have not.

Anyway, I did confirm keeping the transmitter enabled all the time makes
the problem go away.

I suspect the correct fix for this is to take the fix in the ARM tree
for serial_core's console initialisation, and ensure that zs.c handles
the power management of the port (enabling/disabling transmitter)
in the power management callback.

You can find the fix in the mbox archive:

http://ftp.arm.linux.org.uk/pub/linux/arm/kernel/git-cut/arm:devel.mbox

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Linux 2.6.25.9
    ... We are announcing the release of the 2.6.25.9 kernel. ... It contains a number of assorted bugfixes all over the tree. ... x86: set PAE PHYSICAL_MASK_SHIFT to 44 bits. ... Reinstate ZERO_PAGE optimization in 'get_user_pages' and fix XIP ...
    (Linux-Kernel)
  • Re: Announce: Linux-next (Or Andrews dream :-))
    ... And the rate of change in each major portion of the kernel (drivers, ... arch, core, network, etc) is exactly proportional to the amount of the ... and we also tried to simply even re-architect the whole tree so ... And we fix them up, ...
    (Linux-Kernel)
  • Re: RFD: Kernel release numbering
    ... I think your problem is that you really think that the tree _I_ want ... We're always had the "wild" kernels, and 90% of the time the point of the ... the -ac kernel historically very much a "wild" thing, ... In other words, it's not a "let's fix all serious bugs we can fix", but a ...
    (Linux-Kernel)
  • Re: [PATCH 5/6] SUNHME: Workaround ancient hang on U1s
    ... Without it, sunhme hangs fairly ... Dave, I know it's not in the kernel because it isn't a "fix", but given ... of the our tree some one would complain, ...
    (Linux-Kernel)
  • Re: [patch] x86: 2.6.31-rc7 crash due to buggy flat_phys_pkg_id
    ... can you check if this one fix your problem? ... Here's a sample cpuinfo from an older kernel ...
    (Linux-Kernel)