Re: [PATCH] usb-gadget-ether: Prevent oops caused by error interrupt race -V2 (comments update)


On Sat, 2007-09-22 at 12:18 -0700, David Brownell wrote:
I think you misread my comment. Those requests are **NOT** pending!!
So this update has a *MORE* incorrect description of the issue.

That's just the freelist ... it's a fairly conventional model whereby
there's a pool of "free" request slots which can be issued. When the
pool empties, the TX queue shuts down until one of the requests which
is pending in the hardware completes, and makes a slot free.

The problem you're addressing is that there's a small window where a
disconnect IRQ can shut down the TX queue (and empty that freelist)
after upper layers in the network stack started a transmission on
an active (pre-disconnect) TX queue.

That problem is *NOT* related to any pending requests at all!!

Sorry, I misunderstood your comment. Can you please add the correct
comment yourself before we play some more rounds of ping pong ?

tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • RE: IIS 6 features
    ... Each application pool has a queue that is separate from the ... Http.sys is responsible for routing requests to the queue ... compartmentalization, reliability, recoverability, security, yada yada yada. ...
    (Focus-Microsoft)
  • [rfc][patch 2.6.18-rc7] block: explicit plugging
    ... This is a patch to perform block device plugging explicitly in the submitting ... the device idle when it is known more requests will be submitted. ... Explicit plugging keeps a process-private queue of requests being held. ... struct rb_root cic_root; ...
    (Linux-Kernel)
  • Re: output.c error in multithreaded program
    ... >> queue, type C requests in a type C queue. ... But since multiple processes actually involve more overhead than ... limits and didn't pursue the upper bound issue. ...
    (microsoft.public.vc.mfc)
  • Re: Problem of creating control device in a mouse filter driver us
    ... Number of driver owned requests: ... This is WDF internal queue for create requests. ... The control device and filter device seem both have their own IOqueues. ...
    (microsoft.public.development.device.drivers)
  • Re: Thread Question
    ... I added some dummy code to simulate long-running requests, ... from Queue import Queue ... Thread's name into the response Queue. ...
    (comp.lang.python)