[patch 2/2] clockevents: remove the suspend/resume workaround^Wthinko

In a desparate attempt to fix the suspend/resume problem on Andrews
VAIO I added a workaround which enforced the broadcast of the oneshot
timer on resume. This was actually resolving the problem on the VAIO
but was just a stupid workaround, which was not tackling the root
cause: the assignement of lower idle C-States in the ACPI processor_idle
code. The cpuidle patches, which utilize the dynamic tick feature and
go faster into deeper C-states exposed the problem again. The correct
solution is the previous patch, which prevents lower C-states across
the suspend/resume.

Remove the enforcement code, including the conditional broadcast timer
arming, which helped to pamper over the real problem for quite a time.
The oneshot broadcast flag for the cpu, which runs the resume code can
never be set at the time when this code is executed. It only gets set,
when the CPU is entering a lower idle C-State.

Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Tested-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: Len Brown <lenb@xxxxxxxxxx>
Cc: Venkatesh Pallipadi <venkatesh.pallipadi@xxxxxxxxx>
Cc: Rafael J. Wysocki <rjw@xxxxxxx>

---
kernel/time/tick-broadcast.c | 17 +----------------
1 file changed, 1 insertion(+), 16 deletions(-)

Index: linux-2.6/kernel/time/tick-broadcast.c
===================================================================
--- linux-2.6.orig/kernel/time/tick-broadcast.c 2007-09-23 00:00:59.000000000 +0200
+++ linux-2.6/kernel/time/tick-broadcast.c 2007-09-23 00:01:00.000000000 +0200
@@ -382,23 +382,8 @@ static int tick_broadcast_set_event(ktim

int tick_resume_broadcast_oneshot(struct clock_event_device *bc)
{
- int cpu = smp_processor_id();
-
- /*
- * If the CPU is marked for broadcast, enforce oneshot
- * broadcast mode. The jinxed VAIO does not resume otherwise.
- * No idea why it ends up in a lower C State during resume
- * without notifying the clock events layer.
- */
- if (cpu_isset(cpu, tick_broadcast_mask))
- cpu_set(cpu, tick_broadcast_oneshot_mask);
-
clockevents_set_mode(bc, CLOCK_EVT_MODE_ONESHOT);
-
- if(!cpus_empty(tick_broadcast_oneshot_mask))
- tick_broadcast_set_event(ktime_get(), 1);
-
- return cpu_isset(cpu, tick_broadcast_oneshot_mask);
+ return 0;
}

/*

--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [Bug #14859] System timer firing too much without cause
    ... that you worry about the IRQ0 interrupts (which are correct and ... we programm the timer to go off at the ... So you see less timer interrupts (IRQ0 + Local timer interrupts) ... The broadcast mechanism is necessary because the local APIC timer ...
    (Linux-Kernel)
  • Re: [Bug #14859] System timer firing too much without cause
    ... that you worry about the IRQ0 interrupts (which are correct and ... we programm the timer to go off at the ... So you see less timer interrupts (IRQ0 + Local timer interrupts) ... The broadcast mechanism is necessary because the local APIC timer ...
    (Linux-Kernel)
  • Re: Linux 2.6.21-rc1
    ... I don't think in the past IRQ0 stops without the system ... Add broadcast functionality, so per cpu clock event devices can be registere ... This is primarily designed to replace the switch apic timer to / fr ...
    (Linux-Kernel)
  • Re: DECnet between VMS 4.6 and 7.3
    ... Service timer = 4000 ... Designated router = 1.8 ... Broadcast routing timer = 180 ... Maximum buffers = 100 ...
    (comp.os.vms)