Re: [PATCH 1/3] dma: add dma_flags_set/get_*() interfaces

On Wed, 17 Oct 2007 09:03:27 -0700
akepner@xxxxxxx wrote:


What would be the cost of doing this cleanly and either redefining
dma_data_direction to be a field-of-bits or just leave dma_data_direction
alone (it is quite unrelated to this work, isn't it?) and adding new
fields/arguments to manage this new functionality?

It'd be significantly more work to do change or add arguments
to the dma_map_* functions. But if that's what I need to do to
get this accepted, I'll back up and have another go at it.

I don't have any particularly strong opinions on which would be the best
way to clean this up. Hopefully someone who is more involved with the DMA
mapping interfaces can help out.

It wouldn't be efficient for you to implement something new, only to have
it criticized again. I'd suggest that you come up with a concrete
design, describe to us what you propose to do and let's take it from there.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Why a class when there will only be one instance?
    ... > to requires significant mental effort and does add cost. ... Why does greater functionality make a class desireable, ... Other people have mentioned "code reuse". ... pursuit of the goal." ...
    (comp.lang.python)
  • Re: Fast healing and regeneration
    ... >> book he was reading was incomplete. ... >> rules for creature characteristics, ... Is the basic functionality of BASIC GAME ... > suggests that not redefining hit points every time they are mentioned is a ...
    (rec.games.frp.dnd)
  • Re: Fast healing and regeneration
    ... Is the basic functionality of BASIC GAME ... suggests that not redefining hit points every time they are mentioned is a ... since fast healing is defined completely WHERE IT ...
    (rec.games.frp.dnd)
  • Re: Advice needed
    ... Typically when they do that they lose a lot of functionality that they had built over time, while at the same time adding a whole new set of bugs. ... If you are asking them to do a massive rewrite you need to have a convincing business case. ... Will you save on the cost of new hardware enough to justify the cost of new development? ...
    (microsoft.public.dotnet.general)
  • Re: Is there a reason not to do this?
    ... not actually redefining it). ... I'm dealing with some classes whose instances take a long time to ... and it has nothing to do with the functionality ... with the persistence code, and I'm trying to keep things lightweight. ...
    (comp.lang.python)