Re: [PATCH] Fix bad data from non-direct-io read after direct-io write

Linus Torvalds wrote:

On Fri, 26 Oct 2007, Zach Brown wrote:
I can throw together a patch if you haven't already committed one by the
time you read this ;).

I'm not touching that code except to send out possible patches for others
to test and comment on. I have no test-cases, nor any real interest in it.
So yeah, please send me a tested and thought-through patch.

Sure thing. It looks like Karl just sent out the patch I had in mind,
so I'll run it through the tests on Monday. I assume everyone can
handle waiting that long.

It sounded like Karl actually had a test-case to trigger this, but maybe
I'm confused (and it sounds a bit unlikely, since it should be hard to
trigger..

It's disappointingly easy to trigger with ext3 and ordered extending
writes. The invalidation can race with jbd pinning the bhs while it
commits the transaction. It happens that ext3 returns failure from
->releasepage if jbd is committing the transaction.

http://git.kernel.org/?p=linux/kernel/git/zab/aio-dio-regress.git;a=blob;f=c/aio-dio-invalidate-failure.c

Although maybe you can trigger it by doing a direct_IO write
with the *source* being an mmap() of the file you're writing to, and
depending on the write itself re-populating the destination in the page
cache?)

dio will definitely bring the page in with get_user_pages() but I'd like
to think that that pinned page could be safely invalidated out of the
page cache while dio holds a page reference. I've never tried it, though.

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • [PATCH 02/16] DRBD: lru_cache
    ... The lru_cache is a fixed size cache of equal sized objects. ... bitmap, or other meta data. ... For each transaction recording a change to the active set, ... the lru cache to operate on ...
    (Linux-Kernel)
  • Re: Hibernate over-verbose logging
    ... INFO: configuring from resource: /hibernate.cfg.xml ... Using default transaction strategy ... No TransactionManagerLookup configured (in JTA environment, use of read-write or transactional second-level cache is not recommended) ...
    (comp.lang.java.programmer)
  • Re: Can this be done??
    ... >> As far as I know, this is impossible to be achieved in transaction. ... >> the SQL server database engine commits and rolls back transactions by ... the transaction log cannot be ... >> use DataSet.GetChanges to get the newly inserted rows. ...
    (microsoft.public.dotnet.framework.adonet)
  • Identity range problem...
    ... We have an application that use an archive / cache concept: ... creation of an invoice, the transactions are store in a table Cache. ... Each transaction has an unique ID int. ... Because of replication, the article Cache was published using the identity ...
    (microsoft.public.sqlserver.replication)
  • Re: What are dirty pages?
    ... > buffer pool, so it does not match what is on disk. ... > When a transaction commits, the LOG records for that transaction are ...
    (microsoft.public.sqlserver.server)