Re: [PATCH] markers: modpost



* Roland McGrath (roland@xxxxxxxxxx) wrote:
If we want to do it safely, I think we should iterate from
__start___markers to __stop___markers symbols of vmlinux and get the
pointers to the name/format string pairs.

The same can then be done with modules using the __markers section.

Or maybe is there some reason not to do that ?

It's just rather a pain in the ass, a whole lot more fiddly work.
cf "somewhat crude" and "foreseeable future" in my patch's log entry.
Knock yourself out if you're looking for more tedious hacking to do in
modpost.c, but I say fix it when it breaks.


Hmmmm, I have rarely seen code go into mainline without addressing valid
technical criticism first. Please fix.

I'll look into it if I find the time.

Mathieu


Thanks,
Roland

--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: [PATCH] markers: modpost
    ... pointers to the name/format string pairs. ... The same can then be done with modules using the __markers section. ... Or maybe is there some reason not to do that? ...
    (Linux-Kernel)
  • Re: [PATCH] Linux Kernel Markers
    ... Depends what we're trying to fix. ... Flexibility - kprobes seem unable to access all local variables etc ... generate required DWARF information in some cases due to optimizations. ... Djprobes don't depend on markers. ...
    (Linux-Kernel)
  • Re: help wanted to understand reason for test failure (in Games::AlphaBeta)
    ... >> to fix these, but I must admit I'm a bit stumped. ... >> should fail. ... >> Any pointers? ...
    (comp.lang.perl.modules)
  • [patch 18/22] SUNRPC: Fix a performance regression in the RPC authentication code
    ... Fix a regression reported by Max Kellermann whereby kernel profiling ... if the actual pointers are not identical. ...
    (Linux-Kernel)
  • Linux 2.6.25.14
    ... kernel series should upgrade to this version. ... fix fls() for 64-bit arguments ... markers: fix markers read barrier for multiple probes ... cpufreq acpi: only call _PPC after cpufreq ACPI init funcs got called already ...
    (Linux-Kernel)