Re: Fw: Buffer overflow in CIFS VFS.

Steve French wrote:
On Nov 10, 2007 7:03 AM, Przemyslaw Wegrzyn <czajnik@xxxxxxxxxxx> wrote:

Steve French wrote:

That might be better, although without memory pools, this would perform
much worse


Why ? I don't get your point here.

What I meant is that two fixed size memory pools rather variable size
kmallocs helps performance. By using two fixed size buffers (small -
which fits the typical smb request and response, and large which fits
the maximum size request other than write which is handled via an
iovec) and taking advantage of memory pools, cifs can always make
progress even in low memory situations (reducing the likelihood of
deadlock) and it reduces the number of times that cifs has to do the
very expensive allocation of 16.5K. If cifs only used variable size
request and response buffers, since they are frequently more than one
page in size we would be forcing the memory manager to find contiguous
pages which can be very slow.

That was not really my intention to allocate variable size buffers -
it's perfectly Ok for me to have 2 fixed-size pools. What I meant was to
allocate buffers with some kind of header containing buffer size and
type of buffer or whatever needed info. Obviously, you could use
pointers to buffer body all over the code, functions/macros that need to
access the header would move the pointer back by sizeof(header). Then
one could e.g. provide a single function for disposing the buffer, and
no longer care which pool is it allocated from, for the additional
memory cost - the function would look into the header to check that for
you. Hope it's clear now (my English is far from perfect).

Przemyslaw

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Detecting freed memory
    ... can easily see the parent article, or even the subject header. ... The parent article asked about how to detect, after a call to free, ... > buffer that can be checked. ... It would also have to initialize newly malloced memory with some ...
    (comp.lang.c)
  • Re: memory related concerns
    ... i have a situation where i receive data in a buffer and i ... utiltimate aim is to return the header of the linked list to the caller ... run out of memory simultaneously. ...
    (comp.lang.c)
  • Re: memory related concerns
    ... i have a situation where i receive data in a buffer and i ... utiltimate aim is to return the header of the linked list to the caller ... run out of memory simultaneously. ...
    (comp.lang.c)
  • Re: dynamic buffer size
    ... call BeginRead with a buffer big enough to hold the header. ... it may not save you any time or memory to do that since using ... There are packet definitions of variable length. ...
    (microsoft.public.dotnet.languages.csharp)
  • Re: Discovering variable types...
    ... >- but I suppose MS expect us to use wrappers ... memory allocations for your variables from disk as well. ... >They most certainly are of fixed size, changing the size of a String ... >>me to keep buffer size and current postion right in the memory block. ...
    (comp.lang.pascal.delphi.misc)