[PATCH] 2.6.24: restore missing sysfs max_cstate attr



Len, is there any good reason why max_cstate was made invisible in 2.6.24,
breaking my userspace scripts that access it?

Here's a patch to fix the regression from 2.6.23:

Restore visibility of /sys/module/processor/parameters/max_cstate for compatibility with kernels prior to 2.6.24.

I have scripts here that rely upon it.

Signed-off-by: Mark Lord <mlord@xxxxxxxxx>
---

Patch is against 2.6.24-rc3-git5.

--- linux/drivers/acpi/processor_idle.c.orig 2007-11-30 13:35:20.000000000 -0500
+++ linux/drivers/acpi/processor_idle.c 2007-11-30 13:35:31.000000000 -0500
@@ -76,7 +76,7 @@
#define PM_TIMER_TICKS_TO_US(p) (((p) * 1000)/(PM_TIMER_FREQUENCY/1000))

static unsigned int max_cstate __read_mostly = ACPI_PROCESSOR_MAX_POWER;
-module_param(max_cstate, uint, 0000);
+module_param(max_cstate, uint, 0644);
static unsigned int nocst __read_mostly;
module_param(nocst, uint, 0000);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Linux 2.6.19
    ... knowing that it's all your own d*mn fault, and you should just fix your ... [SCSI] ... [PATCH] ... USB: ipaq: Add HTC Modem Support ...
    (Linux-Kernel)
  • Re: Linux 2.6.19
    ... knowing that it's all your own d*mn fault, and you should just fix your ... [SCSI] ... [PATCH] ... USB: ipaq: Add HTC Modem Support ...
    (Linux-Kernel)
  • Re: Top kernel oopses/warnings for the week of May 16th 2008
    ... Sleeping allocation in interrupt context, some in netlink, some in the ... It looks like it wasn't enough to fix all of it, ... regression impact without introducing any other problem compared to ... I think my patch isn't enough yet as I had another crash for the same ...
    (Linux-Kernel)
  • Re: bcm43xx regression in 2.6.24 (with patch)
    ... On Saturday 23 February 2008 12:07:51 Ingo Molnar wrote: ... a regression, it should be fixed at least in the 2.6.24.y series, do ... Alexey had a problem, he analyzed it, he found a fix which he tested, ... || the patch, I'll gladly fix and resend it. ...
    (Linux-Kernel)
  • Re: Pascal family of languages is getting crowded :-)
    ... Then he must do the actual fix, and do local, basic testing to check to ... Then a collection of bugs are put together into a build. ... Perhaps the existing regression test suite ... separating out each SKU for it's own patch. ...
    (borland.public.delphi.non-technical)