Re: [PATCH] net/ipv4/netfilter/ip_tables.c: remove some inlines

On Monday 17 December 2007 14:47, Patrick McHardy wrote:
Please CC netfilter-devel on netfilter patches.

Denys Vlasenko wrote:
Hi Patrick, Harald,

I was working on unrelated problem and noticed that ip_tables.c
seem to abuse inline. I prepared a patch which removes inlines
except those which are used by packet matching code
(and thus are really performance-critical).
I added comments explaining that remaining inlines are
performance critical.

Result as reported by size:

text data bss dec hex filename
- 6451 380 88 6919 1b07 ip_tables.o
+ 6339 348 72 6759 1a67 ip_tables.o

Please take this patch into netfilter queue.

This clashes with my pending patches, which I'll push upstream
today. I also spent some time resyncing ip_tables and ip6_tables
so a diff of both (with some sed'ing) shows only the actual
differences, so please update ip6_tables as well.

I would be happy to rediff the patch.

Which tree should I sync against in order to not collide
with your changes?
--
vda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [Intel IOMMU 04/10] IOVA allocation and management routines
    ... All the inlines in this code are pretty pointless: ... * given doamin which matches the given pfn. ... Adding a comment patch which explains the same. ... * @iovad: iova domain in question. ...
    (Linux-Kernel)
  • [2.6 patch] mxser.c: fix inlines (fwd)
    ... The patch forwarded below is still required in 2.6.8-rc2-mm1. ... to 'mxser_check_modem_status': function body not available ... An alternative approach would be to remove the inlines. ... static void mxser_start; ...
    (Linux-Kernel)
  • Re: Some cleanup patches for: ...lvalues is deprecated
    ... >Please don't include the compiler.h part of your patch. ... and we're currently fixing the inlines ... cast-as-lvalue and fastcall fixes -- I noticed that at least one fix ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: [RFC][PATCH] inline a few tiny functions in init/initramfs.c
    ... >> the patch makes sense, but the malloc() is not clear cut. ... so I'll just send in a patch that inlines the ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: [PATCH] release_pcibus_dev() crash
    ... The patch below augments yours to account ... > comfortable with the ifdef's and inlines:) ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)