Re: [PATCH 01/12] Use mutex instead of semaphore in driver core
- From: "Dave Young" <hidave.darkstar@xxxxxxxxx>
- Date: Sat, 29 Dec 2007 09:52:11 +0800
On Dec 29, 2007 9:42 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
On Sat, 2007-12-29 at 09:36 +0800, Dave Young wrote:
On Dec 29, 2007 9:29 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
Yes, I will try rebuild with lockdep and test.
I'm pretty sure you didn't boot that kernel with lockdep enabled.
I'll fail miserably :-)
From your other mail:
No, I checked the config , lockdep is indeed enabled. But I will try
to test with the lock debug options enabled in a while.
You need to actually boot the kernel to get effective reports from
lockdep, it'll build just fine.
Also, most, if not all, of your patches miss a patch description.
Does the description really needed for it? IMHO, the subject is enough
to descript the patches.
Preferably, the subject might convey what you are doing, but the full
description should at least add to that by telling _why_ you are doing
that.
Hm, actually it's not so hard, but If I resend the 12 patches seems
like spam to lkml :-).
Of cource, if you all don't mind and it is really needed, I will do that.
Also, I don't think your series is bisectable, ie. 1/12 changes
device::sem -> device::mutex, and 12/12 changes a user of it.
Sorry, I don't use git tools now. Could you tell me how to fix it?
thanks in advance.
Regards
dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH 01/12] Use mutex instead of semaphore in driver core
- From: Peter Zijlstra
- Re: [PATCH 01/12] Use mutex instead of semaphore in driver core
- References:
- [PATCH 01/12] Use mutex instead of semaphore in driver core
- From: Dave Young
- Re: [PATCH 01/12] Use mutex instead of semaphore in driver core
- From: Peter Zijlstra
- Re: [PATCH 01/12] Use mutex instead of semaphore in driver core
- From: Dave Young
- Re: [PATCH 01/12] Use mutex instead of semaphore in driver core
- From: Peter Zijlstra
- [PATCH 01/12] Use mutex instead of semaphore in driver core
- Prev by Date: Re: [PATCH 01/12] Use mutex instead of semaphore in driver core
- Next by Date: Re: [PATCH 05/10] x86_64: Use generic percpu
- Previous by thread: Re: [PATCH 01/12] Use mutex instead of semaphore in driver core
- Next by thread: Re: [PATCH 01/12] Use mutex instead of semaphore in driver core
- Index(es):
Relevant Pages
|
