Re: asm-x86/msr.h for sanitized headers: clean it or punt it



On Monday 31 December 2007, Andi Kleen wrote:
Mike Frysinger <vapier@xxxxxxxxxx> writes:
The current asm-x86/msr.h does not actually define anything for
(!__KERNEL__ && __i386__). For x86_64, it fails to build due to u32/u64
types being used. Simply not installing the header seems easiest to me.
Otherwise, x86_64 will need sanitizing and i386 should have things added
back, otherwise it's just a pointless empty header.

Please don't -- asm/msr.h is very useful in user space for rdtscll et.al.
I use it all the time in test programs.

can you enumerate which functions need to actually go to userspace then ? the
__KERNEL__ markings are a crapshoot at the moment. you must also be jumping
through hoops in order to use the header in the first place since the vanilla
one wont compile out of the box.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.



Relevant Pages

  • [PATCH] header install: cosmetic cleanups to kbuild infrastructure
    ... A set of cosmetic cleanups for the header install kbuild infrastructure: ... +# unifdef-y are the files where unifdef will be run before installing files ... .PHONY: altarch-dir ...
    (Linux-Kernel)
  • Re: Load bearing wall vs. shelves
    ... Im a litty wary of taking out the studs and installing a header. ... being there is already a 6-7 foot opening between livingroom and ... kitchen area and right next to where I want to install this wall ...
    (alt.home.repair)
  • Re: headers & footers in excel...
    ... I had the option of> installing a logo in the header. ... I have transfered my templates to this> desktop computer and CAN NOT find my previously installed> logo in these documents on this new computer. ... Do I need to upgrade> my version or is there a way to make this version of> Excel insert/edit pics in the header/footer? ...
    (microsoft.public.excel.misc)
  • Re: asm-x86/msr.h for sanitized headers: clean it or punt it
    ... Simply not installing the header seems easiest to me. ... need sanitizing and i386 should have things added back, ... Signed-Off-By: Mike Frysinger ...
    (Linux-Kernel)
  • Re: asm-x86/msr.h for sanitized headers: clean it or punt it
    ... Mike Frysinger writes: ... Simply not installing the header seems easiest to me. ... need sanitizing and i386 should have things added back, ...
    (Linux-Kernel)