Re: [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to core

On Sun, Dec 30, 2007 at 08:06:34PM +0100, Marcin Slusarz wrote:
There are many places where these functions would be useful.
(just look at: grep -r 'cpu_to_[ble12346]*([ble12346]*_to_cpu.*[-+]' linux-src/)
What do you think?

ps: this patch depends on http://lkml.org/lkml/2007/12/25/35
--

add inline functions which add native byte order variable to
little/big endian variable to core header and as an example
convert ext3 to use them

You might want to note where you got these functions from in your message.

Also, it would be easier to follow these changes if you had broken things up
into two patches - one which moved stuff from ocfs2 into generic helpers and
a 2nd one to convert ext3.

Looking into my crystal ball, I see a bunch of "convert to using byteorder
math macros" patches coming down the pipe. Since we're talking about disk
fields where a mistake could be costly, I suggest that any patch more than a
couple of lines should be tested by the submitter with sparse. A statement
that sparse didn't produce any new warnings (with the patch applied) could
be included in the description.
--Mark

--
Mark Fasheh
Principal Software Developer, Oracle
mark.fasheh@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [PATCH 00/17] per device dirty throttling -v7
    ... Patches are against 2.6.22-rc4-mm2 ... writes in a setup involving a loop dev ... ext3 over loop over ext3 ... Without the patch, in all the cases I've seen deadlocks or long ...
    (Linux-Kernel)
  • Re: [Ext2-devel] [PATCH] fix ext3 mounts at 16T
    ... I need to do some actual IO testing now, but this gets things mounting for a 16T ext3 ... This patch fixes these issues in the kernel: ... and sent the patches to ext2-devel three months ago. ... The patch which fixes overflow problem on ext3: ...
    (Linux-Kernel)
  • Re: [PATCH] Add ext3 data=guarded mode
    ... Here's an updated patch for ext3 data=guarded mode. ... patches in the series are unchanged, and it looks like Linus pulled them ... writes to the last block in the file that made the file bigger but ...
    (Linux-Kernel)
  • Re: + shut-up-warnings-in-ipc-shmc.patch added to -mm tree
    ... >> by converting the macros to empty inline functions. ... > Sorry to be a nuisance, but I'm a little resistant to this patch. ... If we're going to start converting such things, ... static inline void empty_int ...
    (Linux-Kernel)
  • Re: [fake patch] un-inline sysfs_get_kobject and release_sysfs_dirent
    ... These routines are big enough, ... > inline functions. ... Although my previous patches have contributed ... although a previous patch that I posted ...
    (Linux-Kernel)