Re: [PATCH] profile: further Codying Style fixes



On 1/4/08, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
@@ -408,9 +406,8 @@ void profile_hits(int type, void *__pc, unsigned int
nr_hits)
pc = ((unsigned long)__pc - (unsigned long)_stext) >> prof_shift;
atomic_add(nr_hits, &prof_buffer[min(pc, prof_len - 1)]);
}
-#endif /* !CONFIG_SMP */
-
EXPORT_SYMBOL_GPL(profile_hits);
+#endif /* !CONFIG_SMP */

The symbol is now not exported for non-SMP builds which is a change in
functionality.
And thats not acceptable for pure clean-up patches.

Right, i'll update the patch.
Thanks Sam.

Ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: [PATCH] profile: further Codying Style fixes
    ... The symbol is now not exported for non-SMP builds which is a change in functionality. ... And thats not acceptable for pure clean-up patches. ...
    (Linux-Kernel)
  • Re: [opensuse] lists search engine
    ... Henne Vogelsang wrote: ... I just tried to test this functionality in the search box ... Thats why. ... To unsubscribe, e-mail: opensuse+unsubscribe@xxxxxxxxxxxx ...
    (SuSE)
  • Re: Application crashes on CString.Format() call
    ... > (I talked about CString in the "Proposed Solution".) ... I guess thats another one to pragma warning disable. ... I doubt MS would take out that functionality; ... Prev by Date: ...
    (microsoft.public.vc.language)
  • Re: Large files and D2007
    ... ;-) Dude, thats .net. ... functionality.. ... And it seems this particulary GC isn't working if i look at my rediculous delphi's memory consumption;-) ... Rick Carter wrote: ...
    (borland.public.delphi.non-technical)