Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

On Sat, Jan 05, 2008 at 11:30:24AM -0800, Randy Dunlap wrote:
On Sat, 5 Jan 2008 18:41:39 +0300 Al Boldi wrote:


Select SCSI for USB Mass Storage support.


Cc: David Brownell <david-b@xxxxxxxxxxx>
Cc: Greg KH <greg@xxxxxxxxx>
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Al Boldi <a1426z@xxxxxxxxx>

---

--- 23.a/drivers/usb/storage/Kconfig
+++ 23.b/drivers/usb/storage/Kconfig
@@ -2,14 +2,10 @@
# USB Storage driver configuration
#

-comment "NOTE: USB_STORAGE needs SCSI, and 'SCSI disk support' may"
- depends on USB
-comment "also be needed; see USB_STORAGE Help for more information"
- depends on USB
-
menuconfig USB_STORAGE
tristate "USB Mass Storage support"
- depends on USB && SCSI
+ depends on USB
+ select SCSI

We try not to use 'select' on subsystems and try to limit its use
to library-like code that is relatively small. Selecting SCSI
breaks both of those efforts.
...

_You_ are trying to do this.

For kconfig users, "select" is _much_ better than sending them through
different menus.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages