Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl

Thanks, Andi! I think it'd very useful change.

Reminds me this is something that should be actually flagged
in checkpatch.pl too

Andy, it would be good if checkpatch.pl complained about .ioctl =
as opposed to .unlocked_ioctl = ...

Also perhaps if a whole new file_operations with a ioctl is added
complain about missing compat_ioctl as a low prioritity warning?
(might be ok if it's architecture specific on architectures without
compat layer)

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • [PATCH 13/45] KVM: s390: API documentation
    ... user interface that are unique to s390 architecture. ... +This Documentation describes the unique ioctl calls to /dev/kvm, ... +Floating interrupts may be delivered to any virtual cpu in the configuration. ...
    (Linux-Kernel)
  • Re: [PATCH 13/45] KVM: s390: API documentation
    ... user interface that are unique to s390 architecture. ... +This Documentation describes the unique ioctl calls to /dev/kvm, ... +Floating interrupts may be delivered to any virtual cpu in the configuration. ...
    (Linux-Kernel)
  • Re: sensors fun..
    ... Then you stomped in saying that you don't like the _idea_ of the framework without pointing to technical flaws (you mentioned you didn't even looked at the architecture). ... the kernel (with e.g, an ioctl)? ... Look up the meaning of the word policy if you don't belive me. ... If you say "poll every 5 seconds" you give the kernel "die Richtlinie" to look every 5 seconds for the sensor data and to provide it to the application. ...
    (freebsd-arch)
  • Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl
    ... it would be good if checkpatch.pl complained about .ioctl = ... complain about missing compat_ioctl as a low prioritity warning? ... at all on the "compat by default" architectures like sparc or ppc64. ...
    (Linux-Kernel)
  • Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl
    ... as there are different data structures that ... complain about missing compat_ioctl as a low prioritity warning? ... (might be ok if it's architecture specific on architectures without ...
    (Linux-Kernel)