Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D



On Fri, 4 Jan 2008 07:34:39 +0000
Steve Hardy <steve@xxxxxxxxxxxxxxxxxxx> wrote:

Andrew/Jean,

Sorry for the delay - christmas & getting mutt working delayed my
revised patch. Here is an updated patch against 2.6.24-rc6, which
hopefully addresses all comments made so far.

Jean - you mentioned declaring the devices as platform data & writing
a new-style I2C driver - are there any examples of this approach I can
refer to? I simply copied what is/was currently in-tree for this
driver, which seems to work well with the hardware I'm working with (a
COTS CPCI carrier)

Since I've dropped Thunderbird I hope the patch mangling will be
fixed.

Any problem, please let me know.


The above doesn't constitute a usable changelog. I guess we don't really
need anything in this patch but please do remember that the changelog text
should be included in each new rev of a patch.


Signed-Off by Steve Hardy <steve@xxxxxxxxxxxxxxxxxxx>

"Signed-off-by:", please.

Documentation/hwmon/ads7828 | 38 ++++
drivers/hwmon/Kconfig | 10 +
drivers/hwmon/Makefile | 1
drivers/hwmon/ads7828.c | 296 ++++++++++++++++++++++++++++++++++
4 files changed, 345 insertions(+)

I assumed that this is to be merged via Mark's git-hwmon tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • [BK PATCHES] 2.6.x experimental net driver queue
    ... The changelog was getting quite long, so I'm now omitting all but the ... kernel.org in the same directory as its respective patch. ... Well, even after all that work, it was a pretty darn big driver. ... * NAPI support is enabled with CONFIG_E100_NAPI. ...
    (Linux-Kernel)
  • Re: [PATCH] uio: User IRQ Mode
    ... In this mode the user space driver ... is responsible for acknowledging and re-enabling the interrupt. ... This can easily be done without your patch. ...
    (Linux-Kernel)
  • Re: [PATCH] ne.c fix for hibernate and rmmod oops fix
    ... This patch is ready to be merged. ... that was not the case before, because the probe is invasive. ... legacy driver. ... const unsigned char *buf, const int start_page); ...
    (Linux-Kernel)
  • Re: [PATCH] Blackfin: blackfin on-chip SPI controller driver
    ... patch, rather than initial-plus-cleanups. ... Please put this in Kconfig up with the other SPI controller drivers, ... relevant points in the driver. ... place to reverse any DMA mappings ... ...
    (Linux-Kernel)
  • Re: [git patches] libata updates
    ... Bug fixes, and a new driver. ... (fixed in the attached patch). ...     else ... This is incorrect if slave/master devices use different PIO modes ...
    (Linux-Kernel)