Re: Fix x86 32 bit FRAME_POINTER chasing code
- From: Ingo Molnar <mingo@xxxxxxx>
- Date: Thu, 10 Jan 2008 07:54:38 +0100
* Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:
+++ linux-2.6.24-rc7/arch/x86/kernel/traps_32.c
@@ -124,7 +124,8 @@ static inline unsigned long print_contex
unsigned long addr;
addr = frame->return_address;
- ops->address(data, addr);
+ if (__kernel_text_address(addr))
+ ops->address(data, addr);
/*
* break out of recursive entries (such as
* end_of_stack_stop_unwind_function). Also,
@@ -132,6 +133,7 @@ static inline unsigned long print_contex
* move downwards!
*/
next = frame->next_frame;
+ ebp = (unsigned long) next;
if (next <= frame)
thanks, applied. Nice catch!
This patch is simple; I don't know if it's .24 candidate; the bug is
pretty bad but not a recent regression, and there is obviously some
risk with touching this code.
it's a 2.6.24.1 candidate i believe. We trigger plenty of various
crashes during x86.git maintenance and others hit various crashes in
-mm, so by the time .1 is released we'll have it in .25 and can backport
it. Most folks/distros will update to 2.6.24.1 very quickly so there's
no risk of months loss of quality to kerneloops.org data either.
if there's more than 1-2 weeks to the v2.6.24 release we could merge it
right now as well:
Acked-by: Ingo Molnar <mingo@xxxxxxx>
because in a week we'll trigger plenty of crashes in -git based x86
trees and will know about any regressions and will be able to reasonably
trust it.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: Fix x86 32 bit FRAME_POINTER chasing code
- From: Chuck Ebbert
- Re: Fix x86 32 bit FRAME_POINTER chasing code
- From: Adrian Bunk
- Re: Fix x86 32 bit FRAME_POINTER chasing code
- References:
- Fix x86 32 bit FRAME_POINTER chasing code
- From: Arjan van de Ven
- Fix x86 32 bit FRAME_POINTER chasing code
- Prev by Date: [patch] Add a simple backtrace test module
- Next by Date: Re: Make the 32 bit Frame Pointer backtracer fall back to traditional
- Previous by thread: Fix x86 32 bit FRAME_POINTER chasing code
- Next by thread: Re: Fix x86 32 bit FRAME_POINTER chasing code
- Index(es):
Relevant Pages
|
