Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

On Fri, Jan 11, 2008 at 11:58:23AM -0800, Linus Torvalds wrote:
On Fri, 11 Jan 2008, Matthew Wilcox wrote:

So your argument is that MMCONFIG sucks, therefore Linux has to have a
horrible interface to extended PCI config space?

What's *your* point?

MMCONFIG is known broken. If we ever start enabling it more (ie start
using it even if it's not reserved in the e820 tables), all that known
breakage will come and bite us in the *ss.

Ivan's patch doesn't start enabling MMCONFIG in more places than we
currently do. It makes us use conf1 accesses for all accesses below
256 bytes. That fixes all known problems to date.

We need to have some armor-plated underwear to protect against that
ass-biting, and that's what Arjan's patch is.

Tell me what *other* armor plating you could have that actually works?

The armour plating that already exists -- pci=nommconf.

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Help: DGE-560T not recognized by Linux
    ... 256-byte PCI configuration space, and is reachable only via the MMCONFIG ... Can you test this patch out to see if it fixes this problem on your ... So it seems that marvell's driver on 2.6.12 was able to access config space ...
    (Linux-Kernel)
  • Re: [PATCH] Fix boot-time hang on G31/G33 PC
    ... The 'conflict' mentioned in the patch in my case happens ... Are you getting MMCONFIG enabled on your system with 2.6.23? ... In the cases I've seen that have caused problems in the past, where the MMCONFIG area overlaps with where the graphics card BAR ends up during BAR sizing, the BIOS happened to not reserve the MMCONFIG table in the E820 memory map, so current mainline will turn off MMCONFIG. ... This makes the disable-decode change more critical. ...
    (Linux-Kernel)
  • Re: [Fwd: Re: [PATCH 0/5]PCI: x86 MMCONFIG]
    ... Subject: [PATCH 0/5]PCI: x86 MMCONFIG ... MMCONFIG accesses in x86 platforms. ... Why haven't we gotten reports about this before if this is a common ...
    (Linux-Kernel)
  • Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in
    ... subarchitectures that may or may not have conf1. ... But is there a ACPI-compliant/architecture that only offers mmconfig for configuration-space access and no other fallback method? ... If a system has no conf1, but does not have e820+ACPI+MCFG, or does have some other method than mmconfig, it was already irrelevant in the discussion of Ivan's initial patch in december. ... So some administrator action or some driver action (that can optionally use ext-conf-space but does not *rely* on it) could cause some devices to totally disappear. ...
    (Linux-Kernel)
  • Re: 2.6.18-rc1-mm1
    ... PCI: Not using MMCONFIG. ... Greg has a patch to relax this check, and Rajesh has a further patch to ...
    (Linux-Kernel)