Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

On Fri, Jan 11, 2008 at 12:27:06PM -0800, Linus Torvalds wrote:
On Fri, 11 Jan 2008, Matthew Wilcox wrote:

Ivan's patch doesn't start enabling MMCONFIG in more places than we
currently do. It makes us use conf1 accesses for all accesses below
256 bytes. That fixes all known problems to date.

.. and I agree with that patch. But there will be people who try to access
extended space by mistake, and they'll have a hard-locked machine or
something.

But they can't. We limit the size they can access to 256 bytes, unless
the kernel probed address 256 and it worked.

The armour plating that already exists -- pci=nommconf.

No. It needs to be automatic, OR THE OTHER WAY AROUND.

Ie we disable the unsafe feature on purpose, and then force people who
access it to do so *consciously*.

I'd be fine with making mmconfig off by default. Make people pass
pci=mmconf to activate it.

Extended config space is different, for chissake! It's not even like it's
just a bigger normal config space where normal config accesses just
overflow into it. It really does have different rules etc.

Yes, but it's also important to enable some of the PCIe features.

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in
    ... Ivan's patch doesn't start enabling MMCONFIG in more places than we ... It makes us use conf1 accesses for all accesses below ... Extended config space is different, ... just a bigger normal config space where normal config accesses just ...
    (Linux-Kernel)
  • Re: [PATCH 1/1] pci: Block config access during BIST (resend)
    ... It actually only works for 4 byte accesses. ... It will certainly make the patch ... given device could have its config space blocked for a long time. ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • Re: [PATCH] radeonfb: (#2) Implement proper workarounds for PLL accesses
    ... > This patch implements the proper ones, ... > accesses, and thus requires the previous patch to make sure we do not ... > features in the accel init code. ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: NS83820 2.6.0-test5 driver seems unstable on IA64
    ... a patch for the driver in 2.6.0-test5 is appended. ... accesses... ... the console messages saying `unaligned access' ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)