Re: [PATCH 10/16] udf: create common function for changing free space counter
- From: Jan Kara <jack@xxxxxxx>
- Date: Mon, 14 Jan 2008 10:56:55 +0100
On Sat 12-01-08 14:13:31, Marcin Slusarz wrote:
On Fri, Jan 11, 2008 at 12:24:49AM +0100, Jan Kara wrote:OK, fair enough.
On Thu 10-01-08 23:06:26, marcin.slusarz@xxxxxxxxx wrote:Ok. Done.
Signed-off-by: Marcin Slusarz <marcin.slusarz@xxxxxxxxx>Just two minor comment...
CC: Jan Kara <jack@xxxxxxx>
CC: Christoph Hellwig <hch@xxxxxxxxxxxxx>
---Maybe because you use the function for both increasing and decreasing
fs/udf/balloc.c | 49 ++++++++++++++++++++-----------------------------
1 files changed, 20 insertions(+), 29 deletions(-)
diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c
index dc9f8a9..78dbf1d 100644
--- a/fs/udf/balloc.c
+++ b/fs/udf/balloc.c
@@ -140,6 +140,20 @@ static inline int load_block_bitmap(struct super_block *sb,
return slot;
}
+static bool udf_inc_free_space(struct udf_sb_info *sbi,
free space, you could call is udf_add_free_space?
I didn't want to rely on too many patches, so I intentionally left it.
+ u16 partition, u32 cnt)I think macro like le32_add_cpu() just went into the kernel so you could
+{
+ struct logicalVolIntegrityDesc *lvid;
+
+ if (sbi->s_lvid_bh)
+ return false;
+
+ lvid = (struct logicalVolIntegrityDesc *)sbi->s_lvid_bh->b_data;
+ lvid->freeSpaceTable[partition] = cpu_to_le32(le32_to_cpu(
+ lvid->freeSpaceTable[partition]) + cnt);
use that...
I'll convert it together with other le*_add_cpu changes.
Can you ack this patch with udf_inc_free_space rename?Yes.
Acked-by: Jan Kara <jack@xxxxxxx>
Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH 00/16] udf: cleanup
- From: marcin . slusarz
- [PATCH 10/16] udf: create common function for changing free space counter
- From: marcin . slusarz
- Re: [PATCH 10/16] udf: create common function for changing free space counter
- From: Jan Kara
- Re: [PATCH 10/16] udf: create common function for changing free space counter
- From: Marcin Slusarz
- [PATCH 00/16] udf: cleanup
- Prev by Date: Re: regression: 100% io-wait with 2.6.24-rcX
- Next by Date: Re: The ext3 way of journalling
- Previous by thread: Re: [PATCH 10/16] udf: create common function for changing free space counter
- Next by thread: [PATCH 11/16] udf: replace loops coded with goto to real loops
- Index(es):
Relevant Pages
|
|
