Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c?compiling

From: Ingo Molnar <mingo@xxxxxxx>
Date: Fri, 18 Jan 2008 12:02:52 +0100

* Michael Opdenacker <michael-lists@xxxxxxxxxxxxxxxxxx> wrote:

obj-$(CONFIG_PARAVIRT) += paravirt_32.o
-obj-y += pcspeaker.o
-
obj-$(CONFIG_SCx200) += scx200_32.o

+ifdef CONFIG_INPUT_PCSPKR
+ obj-y += pcspeaker.o
+endif

why didnt you make this:

obj-$(CONFIG_INPUT_PCSPKR) += pcspeaker.o

?

Your patch looks fine to me otherwise, obviously if someone disables
PCSPKR intentionally in the .config, the kernel should just do that.
Could you resend it with the above thing fixed, and against x86.git#mm?
The x86.git coordinates are at:

http://redhat.com/~mingo/x86.git/README

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c?compiling
  - From: Michael Opdenacker

References:
- [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c compiling
  - From: Michael Opdenacker
- Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c compiling
  - From: Michael Opdenacker
- Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c compiling
  - From: Matt Mackall
- Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c compiling
  - From: Michael Opdenacker

Prev by Date: [PATCH 004 of 4] md: Fix an occasional deadlock in raid5 - FIX
Next by Date: [PATCH 003 of 4] md: Change ITERATE_RDEV_GENERIC to rdev_for_each_list, and remove ITERATE_RDEV_PENDING.
Previous by thread: Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c compiling
Next by thread: Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c?compiling
Index(es):
- Date
- Thread

Relevant Pages

[PATCH] fix up front-LED Kconfig
... This patch fixes the front-LED Kconfig issues I introduced while ... # InfiniBand support ... +# DMA Clients ... config BLK_DEV_IDE_SWARM ...
(Linux-Kernel)
Re: [-mm] BUG: sleeping function called from invalid context at include/linux/pagemap.h:290
... does do the lock; it also allocates a page table if it's not there, ... revert pagewalker's Kconfig change ... this patch solve this problem temporary. ... config UNEVICTABLE_LRU ...
(Linux-Kernel)
Re: kgdb support in vanilla 2.6.2
... There are a few features in the patch in -mm which I am not ... It has config option that allows it to hook into scheduling ... ....definition of gdb_debug_hook and some functions to keep ifdef ... * Find all the ports using the given irq and shut them down. ...
(Linux-Kernel)
Re: [PATCH] b2c2: make front-ends selectable and include noob option
... > this patch probably needs some touch-up but mainly I am sking the dvb guys why ... > flexcop-pci: will use the HW PID filter. ... > config DVB_B2C2_FLEXCOP ... If you see above, select all frontends is selected by default, ...
(Linux-Kernel)
Re: [PATCH 1/2] Kprobes: Indicate kretprobe support in arch//Kconfig - updated
... for relevant architectures with kprobes support. ... that depend on kretprobes being present in the kernel. ... +config HAVE_KRETPROBES ... Updated patch below. ...
(Linux-Kernel)