Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapped files

Possibly, I didn't see a quick way to break that iteration.
From a quick glance at prio_tree.c the iterator isn't valid anymore
after releasing i_mmap_lock. Fixing that would be,.. 'fun'.

Maybe i_mmap_lock isn't needed at all, since msync holds mmap_sem,
which protects the prio tree as well, no?

I also realized I forgot to copy/paste the prio_tree_iter declaration
and ought to make all these functions static.

But for a quick draft it conveys the idea pretty well, I guess :-)

Yes :)

There could also be nasty performance corner cases, like having a huge
file mapped thousands of times, and having only a couple of pages
dirtied between MS_ASYNC invocations. Then most of that page table
walking would be just unnecessary overhead.

There's something to be said for walking only the dirty pages, and
doing page_mkclean on them, even if in some cases that would be
slower.

But I have a strong feeling of deja vu, and last time it ended with
Andrew not liking the whole thing...

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Garmin GPS 12
    ... particularly became evident when walking in Prague), plus a feeling I ... ought to have a map-capable model in 2008, I'm in the market for an ...
    (sci.geo.satellite-nav)
  • Re: What is the Crew Exploration Vehicle supposed to be?
    ... It is harder than it ought to ... > Perhaps you might try communicating, instead of forcing people to read your mind? ... I have found walking away from all this ... rather relaxing. ...
    (sci.space.policy)
  • Re: News servers again
    ... On Sat, 15 Apr 2006 15:07:12 GMT, chris mcmillan ... We kept on walking, though I did say afterwards I ought to have ...
    (uk.media.radio.archers)
  • Re: CGI and Attenborough
    ... | Watching the start of Attenborough's arj series I was wondering ... | he ought to take Walking with Dinosaurs a stage further. ...
    (uk.rec.sheds)