Re: [PATCH] x86: Construct 32 bit boot time page tables in native format.



On Monday, 28 of January 2008, Ingo Molnar wrote:

* Rafael J. Wysocki <rjw@xxxxxxx> wrote:

Speaking of cleanups, the following one is applicable IMO.

--- linux-2.6.orig/arch/x86/mm/init_32.c
+++ linux-2.6/arch/x86/mm/init_32.c
@@ -444,23 +444,23 @@ static void __init pagetable_init (void)
paravirt_pagetable_setup_done(pgd_base);
}

-#if defined(CONFIG_HIBERNATION) || defined(CONFIG_ACPI)
+#ifdef CONFIG_SUSPEND
/*
* Swap suspend & friends need this for resume because things like the intel-agp
* driver might have split up a kernel 4MB mapping.
*/
-char __nosavedata swsusp_pg_dir[PAGE_SIZE]
+char swsusp_pg_dir[PAGE_SIZE]

thanks, applied.

Thanks. Well, the comment should also be updated as I can see now. I'll send
a separate patch for that.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • [patch] swsusp: kill config_pm_disk
    ... +#ifdef CONFIG_SOFTWARE_SUSPEND ... * Swap suspend & friends need this for resume because things like the intel-agp ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • [patch] remove CONFIG_PM_DISK
    ... # ACPI (Advanced Configuration and Power Interface) Support ... +#ifdef CONFIG_SOFTWARE_SUSPEND ... Swap suspend & friends need this for resume because things like the intel-agp ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • [PATCH] Free swap suspend from dependency on PageReserved
    ... This patch removes the dependency that swap suspend currently has on ... #ifdef CONFIG_NUMA ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: [PATCH 4/4] x86: Final unification of local_{32|64}.h
    ... Ingo Molnar wrote: ... The X86_32 version is just fine as it is protected with ifdef CONFIG_M386 so use it directly. ... btw., now that we have a single unified file, it might make sense to fix these checkpatch complaints: ...
    (Linux-Kernel)
  • Re: [PATCH] module: kzalloc mod->ref
    ... On Tuesday 27 January 2009 23:45:34 Ingo Molnar wrote: ... void; ... +#ifdef CONFIG_SMP ...
    (Linux-Kernel)