Re: [patch] pci: pci_enable_device_bars() fix


* Jeff Garzik <jeff@xxxxxxxxxx> wrote:

Ingo Molnar wrote:
===================================================================
--- linux.orig/drivers/scsi/lpfc/lpfc_init.c
+++ linux/drivers/scsi/lpfc/lpfc_init.c
@@ -1894,7 +1894,7 @@ lpfc_pci_probe_one(struct pci_dev *pdev,
uint16_t iotag;
int bars = pci_select_bars(pdev, IORESOURCE_MEM);
- if (pci_enable_device_bars(pdev, bars))
+ if (pci_enable_device_io(pdev))
goto out;

Look at the line right above it... AFAICS you want
pci_enable_device_mem(), if the mask is selecting IORESOURCE_MEM BARs.

Also a CC to linux-scsi and the driver author would be nice, as they
are the ones with hardware and can verify.

it would have been totally appropriate for me to just send a mail to
lkml with the proper subject line about the breakage. (I might even have
decided to stay completely silent about the issue and fix it for my own
build, letting you guys figure it out.)

Instead i did a search of lkml (based on the function name in the build
error) and figured out where the pull request was on lkml: Greg. I
replied to that mail, he'll obviously know whom else to Cc from that
point on (if anyone). I really didnt want to (nor did i need to) figure
out whether this was some general driver level API change that happen
kernel-wide, or some SCSI specific change. I simply replied to the pull
request whose Cc: line seemed well-populated to me already. I also took
a look at the commit itself and did a quick hack in a hurry to keep the
tests rolling. It really did not occur to me that i should have added
anyone else to the Cc: line, as linux-pci@xxxxxxxxxxxxxxxxxxxxxxxx was
Cc:-ed already so i assumed the interest was from that angle.

( And as this was spent from my family's weekend time and i had no time
and no interest to dig any further than to figure out the "first hop"
of the change that broke the build, and the parties who initiated that
hop. I'm in fact surprised that your and James's answer to my
bugreport is hostility. )

So i find your suggestion that i should have added more people to the
Cc: line unfair on several levels.

This set of changes seemed like 50% guesswork to me, without
consulting the authors :( And unlike many changes, you actually have
to know the hardware [or get clues from surrounding code] to make the
change.

you mean the whole set of changes? Or just mine? Mine was a 30 seconds
guesswork of course, i dont have the hardware, i didnt do the change,
nor did i do anything near that code - i just saw the build failure stop
my testing and sent in this notification and a hack. That's why i sent
it to Greg, as a reply to the mail where he pushed these changes
upstream and who'll know what to do with it from that point on. My patch
can be totally thrown away (and should be, apparently).

but ... i guess next time i'll think twice before sending any bugreports
about or related to the SCSI code anywhere, unless they become really
annoying. Who needs this hassle?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [somewhat OT] binary modules agaaaain
    ... This is my last mail on this subject with lkml cc:ed, ... They can often be solved with some effort (i.e. Intel WLAN driver). ... > the drivers for their hardware for quality reasons. ... I personally hate kernel politics and try to concentrate on kernel hacking. ...
    (Linux-Kernel)
  • [opensuse] openSUSE 10.3 not detecting SATA HD
    ... the sata_sis driver. ... I've tried turning off ACPI in bios and acpi=off which ... openSUSE 10.2 and all my hardware is working fine. ... info.product = 'USB Raw Device Access' ...
    (SuSE)
  • Re: 2008 SBS no longer boots
    ... driver issue initially, the fact that it seems to happen randomly now ... weird with a hardware problem that consistently doesn't get through boot ... other customer, even a 2 week old one, the problem immediately returned. ... There was a time when a server was fired up with a specialized OS and had a battery of tests run against each component to purposefully stress it. ...
    (microsoft.public.windows.server.sbs)
  • Re: Linux, X, ld, gcc, linking, shared libraries and stuff
    ... >> because, originally, video cards / system RAM could NOT afford to have ... > GL actually "copies" everything, but it's done by the graphics card, so ... > anyway if it's not hardware accelerated. ... installed the proper driver, then it zooms around the screen... ...
    (alt.lang.asm)
  • Re: 2008 SBS no longer boots
    ... Any thermal issues and a lot of other hardware problems should show up ... Happen to know a tool to determine driver load order by just having the ... other customer, even a 2 week old one, the problem immediately returned. ... There was a time when a server (even one that had been "burned ...
    (microsoft.public.windows.server.sbs)