Re: [PATCH] [3/3] Enable ACPI extended century handling for 32bit too
- From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
- Date: Sat, 9 Feb 2008 11:39:11 +0100 (CET)
On Fri, 8 Feb 2008, Andi Kleen wrote:
Not that it matters much, see comment in the code.
Signed-off-by: Andi Kleen <ak@xxxxxxx>
---
arch/x86/kernel/rtc.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
Index: linux/arch/x86/kernel/rtc.c
===================================================================
--- linux.orig/arch/x86/kernel/rtc.c
+++ linux/arch/x86/kernel/rtc.c
@@ -112,12 +112,13 @@ unsigned long mach_get_cmos_time(void)
mon = CMOS_READ(RTC_MONTH);
year = CMOS_READ(RTC_YEAR);
-#if defined(CONFIG_ACPI) && defined(CONFIG_X86_64)
- /* CHECKME: Is this really 64bit only ??? */
+ /*
+ * On 32bit not strictly needed because the world ends in 2038
+ * and the code can handle that with the 2 digit heuristics.
+ */
if (acpi_gbl_FADT.header.revision >= FADT2_REVISION_ID &&
acpi_gbl_FADT.century)
century = CMOS_READ(acpi_gbl_FADT.century);
How does this compile with CONFIG_ACPI=n ?
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH] [1/3] Only do century BCD conversion when we know the RTC is BCD
- From: Andi Kleen
- [PATCH] [3/3] Enable ACPI extended century handling for 32bit too
- From: Andi Kleen
- [PATCH] [1/3] Only do century BCD conversion when we know the RTC is BCD
- Prev by Date: Re: CONFIG_HIGHPTE vs. sub-page page tables.
- Next by Date: Re: m68knommu compile error
- Previous by thread: [PATCH] [3/3] Enable ACPI extended century handling for 32bit too
- Next by thread: Re: [PATCH] [1/3] Only do century BCD conversion when we know the RTC is BCD
- Index(es):
Relevant Pages
|
|