Re: Announce: Linux-next (Or Andrew's dream :-))

On Tue, 12 Feb 2008 14:55:31 -0800
Greg KH <greg@xxxxxxxxx> wrote:

On Tue, Feb 12, 2008 at 10:20:44PM +0000, Alan Cox wrote:
I think the best way to get the serial drivers maintained would be to cat
them all onto the end of synclink.c and hope that Paul thinks he did it.

Well I've already broken the buffering so he'd fix it ;)

We have a pile of old ISA drivers that are going to break soon with the
locking changes and a pile of USB drivers that when I looked at the
locking were so terminally broken I couldn't be bothered to fix them.

Let me know which USB ones are broken, I'll work to fix them.

That I noticed doing an audit for unlocking the mctrl functions:

ir-usb: global variables without locking used in per port operations
iuu_phoenix: no locking on internal data structures
mos7840: ditto
option: ditto
kobil_sct: ditto

These drivers do interesting things (where interesting is probably not too
evil on a PC - except ir-usb) involving playing with data structures
without locks. It seems there was some kind of evolution along the way as
some drivers do have a carefully used port private data structure lock
(or two) but many do not.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Announce: Linux-next (Or Andrews dream :-))
    ... Greg KH wrote: ... We have a pile of old ISA drivers that are going to break soon with the ... locking were so terminally broken I couldn't be bothered to fix them. ... mos7840: ditto ...
    (Linux-Kernel)
  • Re: Kitchen sink library -- gap between scripting and compilaton
    ... consider it bad style to typedef pointer types. ... > GLib generally requires the application to do its own locking, ... private data structures. ... of course have a big lock for list, and lock it during the entire ...
    (comp.os.linux.development.apps)
  • Re: MPSAFE TTY schedule
    ... internals of the TTY structure very often. ... where TTY drivers tamper around inside the clist and cblock ... No tty drivers access the internals of clists ... Driver-specific locking for clists is even less of a problem. ...
    (freebsd-arch)
  • Re: MPSAFE TTY schedule
    ... internals of the TTY structure very often. ... where TTY drivers tamper around inside the clist and cblock ... No tty drivers access the internals of clists ... Driver-specific locking for clists is even less of a problem. ...
    (freebsd-current)
  • Re: [patch 5/6] Convert to use mutexes instead of semaphores
    ... underlying races. ... locking is spread over the drivers. ... If we can find a way to safely do the locking in the backlight core I ...
    (Linux-Kernel)