Re: Linux 2.6.25-rc2

On Friday, 15 of February 2008, Linus Torvalds wrote:

Ok,
this kernel is a winner.

Just to show how _much_ of a winner it is, it's been awarded a coveted
"weasel" series name, which should tell you just how good it's going to
be. It's a name revered in Linux kernel history, and as such this brings
back the good old days where if you find a bug, you're almost certainly
simply mistaken, and you probably just did something wrong.

But hey, you can try to prove me wrong. I dare you.

Here you go.

commit 45b503548210fe6f23e92b856421c2a3f05fd034
Author: Laszlo Attila Toth <panther@xxxxxxxxxx>
Date: Tue Feb 12 22:42:09 2008 -0800

[RTNETLINK]: Send a single notification on device state changes.

contains the following gem:

if (tb[IFLA_LINKMODE]) {
- write_lock_bh(&dev_base_lock);
- dev->link_mode = nla_get_u8(tb[IFLA_LINKMODE]);
- write_unlock_bh(&dev_base_lock);
+ if (dev->link_mode != nla_get_u8(tb[IFLA_LINKMODE])) {
+ write_lock_bh(&dev_base_lock);
+ dev->link_mode = nla_get_u8(tb[IFLA_LINKMODE]);
+ write_lock_bh(&dev_base_lock);
+ modified = 1;
+ }
}

and even with that fixed it breaks NetworkManager (on my test box it apparently
can't get the IP address using DHCP). Reverting this commit makes things
work again.

Well, it looks like this patch went to you untested and unreviewed, so may I
gently request that it be reverted from your tree, pretty please?

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: .version keeps being updated
    ... 8993780a6e44fb4e7ed34e33458506a775356c6e is first bad commit ... depends on getting the kernel version from the kernel binary. ... This just restores "linux_banner" as a static string, ... Reverting this from 2.6.20-rc1 made the build behave again, ...
    (Linux-Kernel)
  • Re: BUG during shutdown - bisected to commit e2912009
    ... Reverting that commit from the current kernel doesn't look ... but the commit immediately preceding this one does halt fine. ... Reverting bb6eddf7 gives me a clean shutdown - predictable of course ... PCSP: Make sure you have HPET and ACPI enabled. ...
    (Linux-Kernel)
  • Re: BUG during shutdown - bisected to commit e2912009
    ... Reverting that commit from the current kernel doesn't look ... but the commit immediately preceding this one does halt fine. ... reverting that patch does ... That BUG_ON was removed by reverting that patch, so you can shutdown ...
    (Linux-Kernel)
  • Re: [Regression, post-2.6.37-rc2] Unable to start KDE with 2.6.37-rc3 on Acer Ferrari On
    ... I cannot start KDE with the 2.6.37-rc3 kernel. ... Reverting the following commit: ... I can try reverting these tomorrow if you want me to. ... Well, that's possible, but unfortunately this is a regression in the kernel still. ...
    (Linux-Kernel)
  • Re: T400 suspend/resume regression -- bisected to a mystery merge commit
    ... I first noticed it on a 2.6.31-git9 kernel with a some ... commit: a03fdb76. ... Here's the git bisect log: ... # CPUFreq processor drivers ...
    (Linux-Kernel)