Re: Linux 2.6.25-rc2

On Friday, 15 of February 2008, Linus Torvalds wrote:

Ok,
this kernel is a winner.

Just to show how _much_ of a winner it is, it's been awarded a coveted
"weasel" series name, which should tell you just how good it's going to
be. It's a name revered in Linux kernel history, and as such this brings
back the good old days where if you find a bug, you're almost certainly
simply mistaken, and you probably just did something wrong.

But hey, you can try to prove me wrong. I dare you.

Here you go.

commit 45b503548210fe6f23e92b856421c2a3f05fd034
Author: Laszlo Attila Toth <panther@xxxxxxxxxx>
Date: Tue Feb 12 22:42:09 2008 -0800

[RTNETLINK]: Send a single notification on device state changes.

contains the following gem:

if (tb[IFLA_LINKMODE]) {
- write_lock_bh(&dev_base_lock);
- dev->link_mode = nla_get_u8(tb[IFLA_LINKMODE]);
- write_unlock_bh(&dev_base_lock);
+ if (dev->link_mode != nla_get_u8(tb[IFLA_LINKMODE])) {
+ write_lock_bh(&dev_base_lock);
+ dev->link_mode = nla_get_u8(tb[IFLA_LINKMODE]);
+ write_lock_bh(&dev_base_lock);
+ modified = 1;
+ }
}

and even with that fixed it breaks NetworkManager (on my test box it apparently
can't get the IP address using DHCP). Reverting this commit makes things
work again.

Well, it looks like this patch went to you untested and unreviewed, so may I
gently request that it be reverted from your tree, pretty please?

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: .version keeps being updated
    ... 8993780a6e44fb4e7ed34e33458506a775356c6e is first bad commit ... depends on getting the kernel version from the kernel binary. ... This just restores "linux_banner" as a static string, ... Reverting this from 2.6.20-rc1 made the build behave again, ...
    (Linux-Kernel)
  • Re: [REGRESSION]fan turns at highspeed after suspend2ram
    ... the kernel still compiles and runs on 2.6.25-rc1 with the commit ... Well, this is strange, because one function introduced by this commit is ... Can you send me the patch reverting ...
    (Linux-Kernel)
  • Re: kernel boot hangs after x86: insert_resorce for lapic addr after e820_reserve_resources
    ... Reverting ... only this commit with current git head gives a successful boot. ... see -- the kernel doesn't get far enough to let me grab it). ...
    (Linux-Kernel)
  • cvs-src summary for 21/03/04
    ... You can get old summaries, and an HTML version of this one, at ... As a follow-up to last week's commit of `ICC support for kernel building`, ... Marcel Moolenaar committed code to replace the use of hints ...
    (freebsd-current)
  • Re: bug in 2.6.22-rc2: loop mount limited to one single iso image
    ... > In kernel 2.6.22-rc2 the number of available loop mounts is reduced ... > Kernel 2.6.20.11 does not show that problem. ... sudo mount -o loop cd1.iso m1 ... commit 705962ccc9d21a08b74b6b6e1d3cf10f98968a67 ...
    (Linux-Kernel)