Re: [PATCH] fs/ufs/util.h 2nd parameter of fs32_to_cpu is not boolean
- From: Evgeniy Dushistov <dushistov@xxxxxxx>
- Date: Sat, 16 Feb 2008 23:16:53 +0300
On Sat, Feb 16, 2008 at 08:38:15PM +0100, Roel Kluin wrote:
from: fs/befs/endian.h +33
static inline u32
fs32_to_cpu(const struct super_block *sb, fs32 n)
{
if (BEFS_SB(sb)->byte_order == BEFS_BYTESEX_LE)
return le32_to_cpu((__force __le32)n);
else
return be32_to_cpu((__force __be32)n);
}
The 2nd parameter is not boolean
---
Test the return value, rather than passing a boolean
Signed-off-by: Roel Kluin <12o3l@xxxxxxxxxx>
---
diff --git a/fs/ufs/util.h b/fs/ufs/util.h
index b26fc4d..23ceed8 100644
--- a/fs/ufs/util.h
+++ b/fs/ufs/util.h
@@ -58,7 +58,7 @@ ufs_set_fs_state(struct super_block *sb, struct ufs_super_block_first *usb1,
{
switch (UFS_SB(sb)->s_flags & UFS_ST_MASK) {
case UFS_ST_SUNOS:
- if (fs32_to_cpu(sb, usb3->fs_postblformat == UFS_42POSTBLFMT)) {
+ if (fs32_to_cpu(sb, usb3->fs_postblformat) == UFS_42POSTBLFMT) {
usb1->fs_u0.fs_sun.fs_state = cpu_to_fs32(sb, value);
break;
}
Yeah, in origin patch, which introduced this code was the similar
misprint. It is sad that after review only one was fixed,
and the second go to mainline.
Acked-by: Evgeniy Dushistov <dushistov@xxxxxxx>
--
/Evgeniy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH] fs/ufs/util.h 2nd parameter of fs32_to_cpu is not boolean
- From: Roel Kluin
- [PATCH] fs/ufs/util.h 2nd parameter of fs32_to_cpu is not boolean
- Prev by Date: [PATCH 9/9] ide: IDE_HFLAG_BOOTABLE -> IDE_HFLAG_NON_BOOTABLE
- Next by Date: Re: Linux 2.6.25-rc2 regression: LVM cannot find volume group
- Previous by thread: [PATCH] fs/ufs/util.h 2nd parameter of fs32_to_cpu is not boolean
- Next by thread: [PATCH 1/9] sgiioc4: use ide_find_port()
- Index(es):
Relevant Pages
|
