Re: [PATCH] Add PCI_DEVICE_TABLE macro



On Sun, 17 Feb 2008 13:10:05 +0100 Jonas Bonn wrote:

The definitions of struct pci_device_id arrays should generally follow
the same pattern across the entire kernel. This macro defines this
array as static const and puts it into the __devinitconst section.

Signed-off-by: Jonas Bonn <jonas@xxxxxxxxxxxx>
---
include/linux/pci.h | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/include/linux/pci.h b/include/linux/pci.h
index 87195b6..487d31c 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -389,6 +389,14 @@ struct pci_driver {
#define to_pci_driver(drv) container_of(drv, struct pci_driver, driver)

/**
+ * PCI_DEVICE_TABLE - macro used to describe a pci device table
+ *
+ * This macro is used to create a struct pci_device_id array in a generic
+ * manner.
+ */
+#define PCI_DEVICE_TABLE(_table) static const struct pci_device_id _table[] __devinitconst
+
+/**
* PCI_DEVICE - macro used to describe a specific pci device
* @vend: the 16 bit PCI Vendor ID
* @dev: the 16 bit PCI Device ID
--

Missing kernel-doc notation for the _table parameter. See the
parameters for PCI_DEVICE() below for an example.

---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • [PATCH] Add DECLARE_PCI_DEVICE_TABLE macro
    ... the same pattern across the entire kernel. ... This macro defines this ... array as const and puts it into the __devinitconst section. ...
    (Linux-Kernel)
  • PROBLEM: Panic booting from USB disk in ioremap.c (line 81)
    ... appears to be PCI device enumeration, ... This does not occur when booting from the hard disk, ... We have tried to circumvent the problem by changing the kernel PCI ... 0dfff000-0dffffff: ACPI Non-volatile Storage ...
    (Linux-Kernel)
  • Re: Permanent Kgdb integration into the kernel - lets get with it.
    ... gets added in the future after the macro? ... So Amit, Tom, George, and the rest of the kgdb development gang worked together and came up with a unified version that we now support on SourceForge. ... the kgdb patch back into the mm series and permanently into the kernel ...
    (Linux-Kernel)
  • PROBLEM: in.tftpd + iptables kernel panic
    ... I am running a stable debian install with tftpd 0.17-9 kernel 2.4.26 ... While backing up cisco configs via tftp I caused a kernel panic ... Before first symbol ... 4000-400f: PCI device 1039:5513 ...
    (Linux-Kernel)
  • Re: rmmod while module is in use
    ... > - a PCI device ... > any clue as to how to protect from module unloading while there is still some ... The kernel code is supposed to prevent module removal when it ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)