Re: [PATCH] snd-hda-intel: don't print using snd_printdd on device open



At Sun, 17 Feb 2008 21:40:32 -0500,
Chuck Ebbert wrote:

From: Adel Gadllah <adel.gadllah@xxxxxxxxx>

snd-hda-intel: don't print using snd_printdd on device open

When CONFIG_SND_DEBUG_DETECT is set the hda-intel driver prints verbose
info like this:

ALSA sound/pci/hda/hda_intel.c:1259: azx_pcm_prepare: bufsize=0x4400,
fragsize=0x1100, format=0x11
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x7,
stream=0x5, channel=0, format=0x11
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3,
stream=0x5, channel=0, format=0x11
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3,
stream=0x0, channel=0, format=0x0
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x7,
stream=0x0, channel=0, format=0x0
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3,
stream=0x0, channel=0, format=0x0

Don't print anything in functions that get called when the device gets
opened/prepared for output.

Why? This debug option is explicitly for debugging purposes, and I
see no reason why such behavior is prohibited.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: 2.6.18-stable release plans?
    ... On 22/01/07, Chuck Ebbert wrote: ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ... Plain text mails only, please http://www.expita.com/nomime.html ...
    (Linux-Kernel)
  • Re: sky2 still broken in 2.6.20.3
    ... Chuck Ebbert wrote: ... It looks like the patch that was applied to 2.6.20.2 ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • Re: [patch] i386: print stack size in oops messages
    ... On 6/4/06, Chuck Ebbert wrote: ... Since I always use preempt (it saved me from more than ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • Re: [patch] i386: entry.s::error_code is not safe for kprobes
    ... On Thursday 03 August 2006 12:20, Chuck Ebbert wrote: ... that must be marked unsafe as well. ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • Re: [rfc patch] i386: dont save eflags on task switch
    ... On Fri, 3 Nov 2006, Chuck Ebbert wrote: ... There is no real need to save eflags in switch_to. ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)