Re: [Patch 2/2] powerpc: i2c-isa: add access check to legacy ioports
- From: Jean Delvare <khali@xxxxxxxxxxxx>
- Date: Mon, 18 Feb 2008 14:31:39 +0100
Hi Christian,
On Wed, 13 Feb 2008 18:37:01 +0100, Christian Krafft wrote:
when probing i2c-pca-isa writes to legacy ioports, which crashes the kernel
if there is no device at that port.
This patch adds a check_legacy_ioport call, so probe failes gracefully
and thus prevents the oops.
Signed-off-by: Christian Krafft <krafft@xxxxxxxxxx>
Index: linux.git/drivers/i2c/busses/i2c-pca-isa.c
===================================================================
--- linux.git.orig/drivers/i2c/busses/i2c-pca-isa.c
+++ linux.git/drivers/i2c/busses/i2c-pca-isa.c
@@ -125,6 +125,13 @@ static int __devinit pca_isa_probe(struc
dev_info(dev, "i/o base %#08lx. irq %d\n", base, irq);
+#ifdef CONFIG_PPC_MERGE
+ if (check_legacy_ioport(base)) {
+ dev_err(dev, "I/O address %#08lx is not available\n", base);
+ goto out;
+ }
+#endif
+
if (!request_region(base, IO_SIZE, "i2c-pca-isa")) {
dev_err(dev, "I/O address %#08lx is in use\n", base);
goto out;
I can apply this, no problem. That being said, you might alternatively
just exclude this driver from PPC. It's for a rare device with no known
user, the driver is unmaintained and will hopefully be replaced soon by
a platform driver which will not probe random ports at load time.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [Patch 0/2] add check_legacy_ioport calls to prevent oops
- From: Christian Krafft
- Re: [Patch 2/2] powerpc: i2c-isa: add access check to legacy ioports
- From: Christian Krafft
- [Patch 0/2] add check_legacy_ioport calls to prevent oops
- Prev by Date: Re: 2.6.25-rc2-mm1 (x86 MCE build error)
- Next by Date: Re: [2.6 patch] fs/jbd/journal.c: cleanups
- Previous by thread: Re: [Patch 2/2] powerpc: i2c-isa: add access check to legacy ioports
- Next by thread: Machine check exception with a kernel dependency
- Index(es):
Relevant Pages
|
