Re: [PATCH] ide-cd: fix some codestyle and most of the checkpatch.pl issues

From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
Date: Tue, 26 Feb 2008 23:37:29 +0100

On Tuesday 26 February 2008, Borislav Petkov wrote:

Signed-off-by: Borislav Petkov <petkovbb@xxxxxxxxx>
---
drivers/ide/ide-cd.c | 634 +++++++++++++++++++++++++------------------------
1 files changed, 323 insertions(+), 311 deletions(-)

With 300 lines changed this is not trivial to review/apply anymore
(yeah, I sound like a broken record ;-) and since I've already applied
Paolo's patch from two days ago this one heavily rejects...

Moreover md5sum is different before/after the patch - I tried really hard
to figure out why (by reverting some changes) but finally I gave up.

Please:
- resync
- factor out changes which affect resulting binary
- resubmit

Thanks,
Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] ide-cd: fix some codestyle and most of the checkpatch.pl issues
  - From: Paolo Ciarrocchi

References:
- ide-cd: trivial fixes
  - From: Borislav Petkov
- [PATCH] ide-cd: fix some codestyle and most of the checkpatch.pl issues
  - From: Borislav Petkov

Prev by Date: Re: [PATCH 0/3] Various IDE coding style fixes
Next by Date: Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
Previous by thread: [PATCH] ide-cd: fix some codestyle and most of the checkpatch.pl issues
Next by thread: Re: [PATCH] ide-cd: fix some codestyle and most of the checkpatch.pl issues
Index(es):
- Date
- Thread

Relevant Pages

Re: [PATCH 3/3] ide-{cd,floppy}: do not map all cmds to an sg
... Borislav Petkov wrote: ... Thanks for fixing it but I worry that the patch is not entirely correct ... Also, for reasons of ... drive-by cleanups together with fixes. ...
(Linux-Kernel)
Re: [PATCH] ide-cd: fix some codestyle and most of the checkpatch.pl issues
... With 300 lines changed this is not trivial to review/apply anymore ... (yeah, I sound like a broken record;-) ... Paolo's patch from two days ago this one heavily rejects... ...
(Linux-Kernel)
Re: [PATCH 4/32] ide-tape: remove struct idetape_mode_parameter_header_t
... Borislav Petkov wrote: ... this code goes away in patch #5 so I dropped this chunk ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
(Linux-Kernel)
Re: [PATCH 2/8] ide-atapi: assign expiry and timeout based on device type
... Borislav Petkov wrote: ... If we add dev_is_idecdcheck here in patch #1 it won't be necessary to ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
(Linux-Kernel)
Re: [PATCH 04/17] ide-tape: remove idetape_empty_write_pipeline()
... Borislav Petkov wrote: ... this is only a temporary measure (git-bisect) ... before removing pipeline functionality completely. ... this patch has the same problems as patch #3 => skipped ...
(Linux-Kernel)