trivial clean up to zlc_setup
- From: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
- Date: Fri, 29 Feb 2008 15:19:39 +0900
Hi
I found very small bug during review mel's 2 zonelist patch series.
this patch is trivial clean up.
jiffies subtraction may cause overflow problem.
it shold be used time_after().
Thanks.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
CC: Lee Schermerhorn <Lee.Schermerhorn@xxxxxx>
CC: Paul Jackson <pj@xxxxxxx>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/mm/page_alloc.c
===================================================================
--- a/mm/page_alloc.c 2008-02-18 17:17:25.000000000 +0900
+++ b/mm/page_alloc.c 2008-02-29 15:17:03.000000000 +0900
@@ -1294,7 +1294,7 @@ static nodemask_t *zlc_setup(struct zone
if (!zlc)
return NULL;
- if (jiffies - zlc->last_full_zap > 1 * HZ) {
+ if (time_after(jiffies, zlc->last_full_zap + HZ)) {
bitmap_zero(zlc->fullzones, MAX_ZONES_PER_ZONELIST);
zlc->last_full_zap = jiffies;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: trivial clean up to zlc_setup
- From: Paul Jackson
- Re: trivial clean up to zlc_setup
- From: Andrew Morton
- Re: trivial clean up to zlc_setup
- Prev by Date: Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and &
- Next by Date: Re: [PATCH 2.6.25] module: allow ndiswrapper to use GPL-only symbols
- Previous by thread: linux-next: Tree for Feb 29
- Next by thread: Re: trivial clean up to zlc_setup
- Index(es):