Re: [PATCH 0/2] firewire: endinaness warnings (was Re: sparse - make __CHECK_ENDIAN__ default enabled?)
- From: Jarod Wilson <jwilson@xxxxxxxxxx>
- Date: Sat, 1 Mar 2008 00:23:24 -0500
On Saturday 23 February 2008 06:23:30 am Stefan Richter wrote:
On 20 Feb, Harvey Harrison wrote on LKML:
On Wed, 2008-02-20 at 23:03 +0100, Sam Ravnborg wrote:
Hi Harvey.
Can I ask you to look into the worst offenders so we
can make -D__CHECK_ENDIAN__ enabled per default
in the kernel.
Or maybe we should do it anyway?
Well, I've got the worst of fs and drivers/ata done so far, still
weeping over the 5500 warnings in drivers. (X86_32 allyesconfig).
People ignore the existing warnings anyway, why not toss a few more
on the pile?
I'll look them over tonight and see how bad it would be.
I looked into drivers/firewire and drivers/ieee1394. As expected, there
are quite a lot endianess related warnings in the latter because this is
code from way before sparse was regularly used.
There are also a few warnings in the former, even though sparse checks
were run before submission of the whole drivers/firewire stack. I will
follow up with two patches:
1/2 firewire: endianess fix
2/2 firewire: endianess annotations
Whether the "fix" is really a fix remains to be seen; I don't have a big
endian Linux box myself.
Doesn't hurt anything on my end, spb2 devices work, they survive bus resets
and so on. The funky uninorth controller definitely doesn't work, but it
didn't before the patch either, and the fix is being chased in another patch
series.
Signed-off-by: Jarod Wilson <jwilson@xxxxxxxxxx>
--
Jarod Wilson
jwilson@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Prev by Date: Re: [PATCH 4/4] ACPI PCI slot detection driver
- Next by Date: Re: [PATCH]iommu-iotlb-flushing
- Previous by thread: Re: [PATCH 4/4] ACPI PCI slot detection driver
- Next by thread: Re: [stable] [PATCH] x86_64 ia32 syscall restart fix
- Index(es):
Relevant Pages
|
