ide_register_hw(): buggy code
- From: Adrian Bunk <bunk@xxxxxxxxxx>
- Date: Sun, 2 Mar 2008 17:19:24 +0200
The Coverity checker spotted the following bogus change to
ide_register_hw() in commit 9e016a719209d95338e314b46c3012cc7feaaeec:
<-- snip -->
...
+ hwif = ide_deprecated_find_port(hw->io_ports[IDE_DATA_OFFSET]);
+ index = hwif->index;
+ if (hwif)
+ goto found;
for (index = 0; index < MAX_HWIFS; index++)
...
<-- snip -->
It's impossible to reach the for() loop without Oopsing before.
Can you either fix this for 2.6.25 or push your patch that removes
ide_register_hw() for 2.6.25?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: ide_register_hw(): buggy code
- From: Peter Teoh
- Re: ide_register_hw(): buggy code
- Prev by Date: Re: epoll design problems with common fork/exec patterns
- Next by Date: Re: Xen paravirt frontend block hang
- Previous by thread: Re: epoll design problems with common fork/exec patterns
- Next by thread: Re: ide_register_hw(): buggy code
- Index(es):
Relevant Pages
|
