Re: [PATCH] block: fix residual byte count handling
- From: Tejun Heo <htejun@xxxxxxxxx>
- Date: Mon, 03 Mar 2008 13:09:13 +0900
FUJITA Tomonori wrote:
- I think bugs caused by using raw_data_len instead of data_len are more
subtle than the other way around. Using data_len instead of
raw_data_len usually affects the application layer while using
raw_data_len instead of data_len affects the DMA engine and transport layer.
If we add extra_len, we can get what raw_data_len and data_len
provide.
I can't see what changing the meaning of rq->data_len (and
investigating all the block drivers) gives us.
No matter which way you go, you change the meaning of rq->data_len and
you MUST inspect rq->data_len usage whichever way you go. Apply your
patch and try to do sg IO on IDE cdrom w/ various transfer lengths.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] block: fix residual byte count handling
- From: FUJITA Tomonori
- [PATCH 1/2] block: fix residual byte count handling
- From: Tejun Heo
- Re: [PATCH] block: fix residual byte count handling
- References:
- Re: [PATCH] block: fix residual byte count handling
- From: Tejun Heo
- Re: [PATCH] block: fix residual byte count handling
- From: FUJITA Tomonori
- Re: [PATCH] block: fix residual byte count handling
- From: Tejun Heo
- Re: [PATCH] block: fix residual byte count handling
- From: FUJITA Tomonori
- Re: [PATCH] block: fix residual byte count handling
- Prev by Date: Re: [PATCH] VIRTIO NET: Enable netpoll interface for netconsole logging
- Next by Date: Re: [patch 1/2] add ALL_CPUS option to stop_machine_run()
- Previous by thread: Re: [PATCH] block: fix residual byte count handling
- Next by thread: [PATCH 1/2] block: fix residual byte count handling
- Index(es):
Relevant Pages
|
