Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors


Many devices today are of a less than stellar quality, and singing
capacitors are a common problem. A high-pitch noise is created, caused
by power fluctuations as the processor enters and leaves deep sleep at
a high frequency.

Instead of just disabling the deep sleep (which wastes power), this
patch allows you to reduces the number of times it is entered so that
the frequency can be kept inaudible.

Signed-off-by: Pierre Ossman <drzeus@xxxxxxxxx>
--

I'm not religious about the default value, and since Dave Jones piped
in I guess one of my major arguments are gone. :)

Here's the same patch with the default set to 0 (effectively disabling
the patch).

diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c
index 78d77c5..d9c43e3 100644
--- a/drivers/cpuidle/governors/menu.c
+++ b/drivers/cpuidle/governors/menu.c
@@ -16,6 +16,8 @@

#define BREAK_FUZZ 4 /* 4 us */

+static unsigned int min_deep_sleep = 0;
+
struct menu_device {
int last_state_idx;

@@ -50,6 +52,19 @@ static int menu_select(struct cpuidle_device *dev)
break;
if (s->exit_latency > pm_qos_requirement(PM_QOS_CPU_DMA_LATENCY))
break;
+
+ /*
+ * In order to avoid the problem of "singing capacitors",
+ * don't enter a deep sleep for short durations (a value
+ * of 2 ms is usually sufficient). This will, hopefully,
+ * keep the problem inaudible.
+ */
+ if (s->flags & CPUIDLE_FLAG_DEEP) {
+ if (min_deep_sleep > data->expected_us)
+ break;
+ if (min_deep_sleep > data->predicted_us)
+ break;
+ }
}

data->last_state_idx = i - 1;
@@ -132,6 +147,9 @@ static void __exit exit_menu(void)
cpuidle_unregister_governor(&menu_governor);
}

+module_param(min_deep_sleep, uint, 0644)
+MODULE_PARM_DESC(min_deep_sleep, "min time (us) to spend in deep sleep to avoid noise")
+
MODULE_LICENSE("GPL");
module_init(init_menu);
module_exit(exit_menu);

--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • [RFC][PATCH] cpuidle: avoid singing capacitors
    ... by power fluctuations as the processor enters and leaves deep sleep at ... a high frequency. ... patch merely reduces the number of times it is entered so that the ... unsigned int last_measured_us; ...
    (Linux-Kernel)
  • Re: [RFC][PATCH] cpuidle: avoid singing capacitors
    ... by power fluctuations as the processor enters and leaves deep sleep at ... a high frequency. ... Instead of just disabling the deep sleep. ... sure that you only reference jiffies on idle exit after the clock ...
    (Linux-Kernel)
  • Re: [RFC][PATCH] cpuidle: avoid singing capacitors
    ... A high-pitch noise is created, ... by power fluctuations as the processor enters and leaves deep sleep at ... a high frequency. ... Instead of just disabling the deep sleep. ...
    (Linux-Kernel)