Re: mpparse_{32,64}.c merge questions



On Tuesday 04 March 2008, Ingo Molnar wrote:

(more folks Cc:-ed)

* Alexey Starikovskiy <astarikovskiy@xxxxxxx> wrote:

I've decided to start with merge of mpparse files, and I'd like to
know your opinion on some differences... Ingo, I know you work on
merging the 32/64 files, do I step on your toes?

My suggestion would be to do a redesign first and then do that for
both.
I was thinking that redesign on one file would go easier... And we
don't need both, do we?

we dont, but please do _not_ "redesign" anything during unification.

try to keep it simple and bisectable. Lots of small patches. Stupid
#ifdefs if need to be. Pick the 32-bit version or the 64-bit version of
any approach, if it's obvious that the unified version will still work
fine. Ask if in doubt.


I agree with Ingo on the "keep it simple" merge steps..

I can't resist mentioning, however, what I'd like to see long term.

I'd like to see mpparse.o depend on CONFIG_MPS=y
I'd like to be able to build CONFIG_ACPI=y and CONFIG_MPS=n

Andy Grover prototyped splititing MPS from ACPI a while back,
but it never made it upstream.

thanks,
-Len
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: Attempted summary of "RT patch acceptance" thread
    ... On Mon, 13 Jun 2005, Karim Yaghmour wrote: ... > Nicolas Pitre wrote: ... >> current stock kernel for that matter, and Ingo even agreed to that. ... discussion on merging issues are rather premature at this point. ...
    (Linux-Kernel)
  • Re: Attempted summary of "RT patch acceptance" thread
    ... > discussion on merging issues are rather premature at this point. ... Ingo, however, is ... well then please read my proposals in light of the sub-topic ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: Attempted summary of "RT patch acceptance" thread
    ... The best way to do this stuff has already been outlined by Ingo himself, ... So any discussion about merging of PREEMPT_RT into mainline is simply ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: [PATCH 1/2] Introduce copy_user_handle_tail routine
    ... review cycles (ie Ingo &co), but the current series is largely ack'ed ... applied them to tip/x86/core, for v2.6.27 merging, thanks everyone. ... I've added Linus's Acked-by. ...
    (Linux-Kernel)
  • RE: futex question
    ... (Cc:-ed more futex folks.) ... That is great but I am wondering, what's your opinion on this Ingo? ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
    (Linux-Kernel)