Re: [ANNOUNCE] Btrfs v0.13

From: Alex Chiang <achiang@xxxxxx>
Date: Mon, 31 Mar 2008 15:02:52 -0600

* Chris Mason <chris.mason@xxxxxxxxxx>:

Great, thanks I'll take these two. The kernel side needs the
same hash.c fix, but I've already got that change made locally.

Here's a patch for the kernel side.

/ac

Subject: [PATCH] btrfs: Stop trashing 'name' arg of btrfs_name_hash
From: Alex Chiang <achiang@xxxxxx>

In btrfs_name_hash, Local variable 'buf' is declared as

__u32 buf[2];

but we then try to do this:

buf[0] = 0x67452301;
buf[1] = 0xefcdab89;
buf[2] = 0x98badcfe;
buf[3] = 0x10325476;

Oops. Fix buf to be the proper size.

Signed-off-by: Alex Chiang <achiang@xxxxxx>

diff -r e4cd88595ed7 -r 03942eecb56d hash.c
--- a/hash.c Thu Feb 21 14:54:12 2008 -0500
+++ b/hash.c Mon Mar 31 14:58:00 2008 -0600
@@ -81,7 +81,7 @@ u64 btrfs_name_hash(const char *name, in
__u32 hash;
__u32 minor_hash = 0;
const char *p;
- __u32 in[8], buf[2];
+ __u32 in[8], buf[4];
u64 hash_result;

if (len == 1 && *name == '.') {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

References:
- Re: [ANNOUNCE] Btrfs v0.13
  - From: Alex Chiang
- Re: [ANNOUNCE] Btrfs v0.13
  - From: Chris Mason

Prev by Date: [2.6 patch] the scheduled i386/x86_64 bzImage symlinks removal
Next by Date: Re: 2.6.25-rc7 : hibernation sometimes not resuming on Dell Latitude D630
Previous by thread: Re: [ANNOUNCE] Btrfs v0.13
Next by thread: [PATCH 1/2] btrfs-progs: Fix printf format casting errors
Index(es):
- Date
- Thread

Relevant Pages

Linux-2.4.31-hf1
... I still produce updates for this kernel. ... Fix cmsg length checks in
Solaris emulation layer. ... [PATCH] ... Check for canonical addresses in ptrace
... (Linux-Kernel)
Re: PATCH/RFC: [kdump] fix APIC shutdown sequence
... , and perhaps fix the dest ID, instead of ... totally clearing the registers.
... You are talking about EOI sent in the kdump kernel, ... With my patch
... (Linux-Kernel)
Re: Cant start up the FreeBSD install disk on dual Xeon Nocona rig (itworks on other systems)
... > I found this fix on a mailing list archive using Google: ... In order to
patch the kernel, ... Then rebuild the GENERIC kernel and install it onto
your new drive. ... (freebsd-questions)
Re: vm86.c audit_syscall_exit() call trashes registers
... Your fix seems to have remedied a problem we are having with EDID fetches through vm86.c.
... we're trying to understand your cleanup so as to back port it to an earlier rev of
the kernel. ... Fitzhardinge's patch. ... (Linux-Kernel)
Re: [PROPOSAL/PATCH] Remove PT_GNU_STACK support before 2.6.11
... number of other options as well even without this kernel fix, ... or to add
a oneliner patch to their heap of 1500+ ... send the line "unsubscribe linux-kernel"
in ... (Linux-Kernel)