Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
- From: David Miller <davem@xxxxxxxxxxxxx>
- Date: Tue, 15 Apr 2008 01:01:31 -0700 (PDT)
From: Andi Kleen <andi@xxxxxxxxxxxxxx>
Date: Tue, 15 Apr 2008 09:59:40 +0200
Vitaliy Gusev <vgusev@xxxxxxxxxx> writes:
Hello!
tcp_prune_queue() doesn't prune an out-of-order queue at all.
Why are you saying this? It has code to prune the ooo queue. You're even
moving it in your patch.
You're saying that the code doesn't work? If yes why?
There are inappropriate guards there, and it didn't get invoked
from another important code path.
That's what his change is fixing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
- From: Andi Kleen
- Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
- References:
- [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
- From: Vitaliy Gusev
- Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
- From: Andi Kleen
- [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
- Prev by Date: Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
- Next by Date: Re: regression caused by: genirq: do not leave interupts enabled on free_irq
- Previous by thread: Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
- Next by thread: Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
- Index(es):
Relevant Pages
|