Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue



From: Andi Kleen <andi@xxxxxxxxxxxxxx>
Date: Tue, 15 Apr 2008 09:59:40 +0200

Vitaliy Gusev <vgusev@xxxxxxxxxx> writes:

Hello!

tcp_prune_queue() doesn't prune an out-of-order queue at all.

Why are you saying this? It has code to prune the ooo queue. You're even
moving it in your patch.

You're saying that the code doesn't work? If yes why?

There are inappropriate guards there, and it didn't get invoked
from another important code path.

That's what his change is fixing.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: merge in turn
    ... were saying: ... >>> If all the traffic keeps moving there won't be a queue will there? ... > Becaus it will merge at speed not at a slow crawl. ...
    (uk.rec.driving)
  • Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
    ... It has code to prune the ooo queue. ... moving it in your patch. ... You're saying that the code doesn't work? ... There are inappropriate guards there, ...
    (Linux-Kernel)
  • Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
    ... It has code to prune the ooo queue. ... moving it in your patch. ... You're saying that the code doesn't work? ...
    (Linux-Kernel)
  • Re: The Dock through the years
    ... You are talking about moving your wrist, ... some edge of the Launcher visible and that was very convenient and easy ... means saying no means you were wrong. ... Trust me, a lot easier. ...
    (uk.comp.sys.mac)
  • Re: /bin/ls sorting bug?
    ... Are you saying that you've never been ... Either commit the patch, ... it might now be time to stop bikeshedding. ...
    (freebsd-hackers)