Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
- From: Andi Kleen <andi@xxxxxxxxxxxxxx>
- Date: Tue, 15 Apr 2008 10:14:56 +0200
David Miller <davem@xxxxxxxxxxxxx> writes:
From: Andi Kleen <andi@xxxxxxxxxxxxxx>
Date: Tue, 15 Apr 2008 09:59:40 +0200
Vitaliy Gusev <vgusev@xxxxxxxxxx> writes:
Hello!
tcp_prune_queue() doesn't prune an out-of-order queue at all.
Why are you saying this? It has code to prune the ooo queue. You're even
moving it in your patch.
You're saying that the code doesn't work? If yes why?
There are inappropriate guards there, and it didn't get invoked
from another important code path.
That's what his change is fixing.
Perhaps I'm dense, but I don't see the inappropiate guards. The
guards are pretty much the same as before.
The main difference seems to be that
sk_rmem_schedule/__sk_mem_schedule is called more often, but it is
unclear how this affects the ooo pruning which only checks
the queue length anyways.
-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
- From: David Miller
- Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
- References:
- [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
- From: Vitaliy Gusev
- Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
- From: Andi Kleen
- Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
- From: David Miller
- [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
- Prev by Date: Re: [PATCH] x86_64/mm: check and print vmemmap allocation continuous -fix
- Next by Date: Re: [PATCH] x86_64: restore mask_bits in msi shutdown
- Previous by thread: Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
- Next by thread: Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
- Index(es):
Relevant Pages
|
