Re: + nfsd-use-proc_create-to-setup-de-proc_fops.patch added to -mm tree



On Sun, Apr 20, 2008 at 08:21:49PM +0400, Denis V. Lunev wrote:

On Sun, 2008-04-20 at 18:37 +0400, Alexey Dobriyan wrote:
On Tue, Apr 15, 2008 at 04:55:57PM -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
--- a/fs/nfsd/nfsctl.c~nfsd-use-proc_create-to-setup-de-proc_fops
+++ a/fs/nfsd/nfsctl.c

@@ -736,10 +737,9 @@ static int create_proc_exports_entry(voi
entry = proc_mkdir("fs/nfs", NULL);
if (!entry)
return -ENOMEM;
- entry = create_proc_entry("fs/nfs/exports", 0, NULL);
+ entry = proc_create("exports", 0, entry, &exports_operations);
^^^^^^^^^
^^^^^^^
if (!entry)
return -ENOMEM;
- entry->proc_fops = &exports_operations;

"fs/nfs/exports" is used in full in this file. And line will fit into
80 columns.

This is a pde for fs/nfs.

Yes, why change it?

So, this will be slightly less operations in my case.

It's done once per module loading, so nobody cares.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: module compiler version check still needed?
    ... check during module loading? ... AFAIK on i386 it was only needed to handle ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • Re: [PATCH] x86: properly annotate alternatives.c
    ... data is needed post-init for module loading only, ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • Re: [PATCH] module: return error when mod_sysfs_init() failed
    ... then the module loading will succeed accidentally. ... This patch makes load_modulereturn error correctly in that case. ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • Re: FINALLY caught a panic
    ... module loading may end up at different memory locations. ... Plain numeric Oops definitely does not help. ... send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • Re: FAQ Topic - What books are recommended for javascript? (2009-05-29)
    ... personality by forging yet another FAQ topic post. ... Nobody cares what you see. ...
    (comp.lang.javascript)