Re: [PATCH 1/1] x86: fix text_poke



On Mon, 28 Apr 2008, Jiri Slaby wrote:

Thanks. Bisected mm down to git-x86.patch, bisected git-x86-latest down to
x86: enhance DEBUG_RODATA support - alternatives
The patch below fixes the problem for me. Comments welcome.

You're a hero, Jiri.

And that also explains why I didn't see it - I don't do modules.

Thanks a heap.

The 0xf0 pattern comes from alternatives_smp_lock:
text_poke(*ptr, ((unsigned char []){0xf0}), 1);

And we should really add a lot more sanity checking there.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [PATCH 1/1] x86: fix text_poke
    ... bisected git-x86-latest ... problems with a pure CPU hotplug stress-test, on a modular kernel. ... Below is that patch from ...
    (Linux-Kernel)
  • Re: FP in kernelspace
    ... Jiri Slaby wrote: ... I have a driver written for 2.4 + RT patches with FP support. ... faculty of informatics, masaryk university, brno, cz ...
    (Linux-Kernel)
  • Re: [PATCH 1/1] Char: n_tty, include module.h
    ... Jiri Slaby wrote: ... NAK ... Maybe the patch didn't come to you yet. ... Ask Andrew to drop it instead. ...
    (Linux-Kernel)
  • Re: DMI year "00" + ACPI [was: DMI: fix dmi_get_year year parsing]
    ... Jiri Slaby wrote: ... BTW. the patch above is not useful, reporting 1908 and 1909 as a year is ... regression with 00/00/00 entries so that acpi gets unintentionally armed ... I don't know if it's worth it. ...
    (Linux-Kernel)
  • Re: PL2303 Driver missing support for USB to Serial Cable
    ... Jiri Slaby wrote: ... into it I discovered that it is based on the Prolific chipset using the ... sufficient and, as I am currently working on the pl2303 driver, you can ... rest assured that it will be included in the patch that I send. ...
    (Linux-Kernel)