Re: [patch, -git] input: CONFIG_INPUT_APANEL build fix


* Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:

On Wed, Apr 30, 2008 at 08:54:16PM +0200, Ingo Molnar wrote:

x86.git testing found this build failure in upstream -git:

drivers/built-in.o: In function `apanel_detach_client':
apanel.c:(.text+0x3027af): undefined reference to `led_classdev_unregister'
drivers/built-in.o: In function `apanel_probe':
apanel.c:(.text+0x302ac9): undefined reference to `led_classdev_register'

with this config:

http://redhat.com/~mingo/misc/config-Wed_Apr_30_20_22_20_CEST_2008.bad

this driver has a missing CONFIG_NEW_LEDS dependency.

Thank you Ingo. Isn't this a Kconfig issue though? I know that Roman
is not willing to fix SELECT to evaluate the whole dependency chain,
but in this case it is "depens on" that does not evaluate properly...

yes and no. It can be fixed in Kconfig but i'm not going to flame yet
another person about long-existing unfixed infrastructure bugs ;-)

The current (many years old) rule is to fix things up as much as we can
and never expose build errors, because 1) randconfig testing is way too
useful and because 2) users can stumble across that .config combination
as well and get rightfully grumpy at us about breaking their build. Most
of the thousands of drivers are fine - it's those with more complex
Kconfig dependencies that have trouble.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [PATCH] drm, i915: select framebuffer support automatically
    ... CONFIG_FB and just call make oldconfig, or even make config and don't ... know that you loose the DRM. ... We can't actually do this, if you don't have a DRM driver for the hw, ... posted to the mailing list two weeks ago about the insane dependency ...
    (Linux-Kernel)
  • Re: 2.6.16-mm1
    ... the config file. ... So it would seem to be a Kconfig bug. ... The basic idea is that the dependency only enables the default and the ... In the meantime the Kconfig syntax has grown and this is not the first ...
    (Linux-Kernel)
  • [PATCH] drm, i915: select framebuffer support automatically
    ... CONFIG_FB and just call make oldconfig, or even make config and don't ... While CONFIG_FB is an interactive Kconfig option so a select can be ... posted to the mailing list two weeks ago about the insane dependency ...
    (Linux-Kernel)
  • Re: [patch, -git] input: CONFIG_INPUT_APANEL build fix
    ... this driver has a missing CONFIG_NEW_LEDS dependency. ... Isn't this a Kconfig issue though? ... The current rule is to fix things up as much as we can ...
    (Linux-Kernel)
  • Re: [patch 01/10] e1000e: make E1000E default to the same kconfig setting as E1000
    ... Make E1000E default to the same kconfig setting as E1000. ... kernel hackers that do their own configs are expected to be able to ... thought into the Kconfig selection and driver migration strategies. ... know about a necessary config update. ...
    (Linux-Kernel)