Re: [patch] input: JOYSTICK_XPAD build fix

From: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
Date: Wed, 30 Apr 2008 17:02:50 -0400

On Wed, Apr 30, 2008 at 10:03:40PM +0200, Ingo Molnar wrote:

x86.git testing found the following build failure in -git:

ERROR: "led_classdev_register" [drivers/input/joystick/xpad.ko] undefined!
ERROR: "led_classdev_unregister" [drivers/input/joystick/xpad.ko] undefined!

which triggers with the following config:

http://redhat.com/~mingo/misc/config-Wed_Apr_30_21_43_17_CEST_2008.bad

the reason is dependency on NEW_LEDS that was not spelled out in the
Kconfig entry of JOYSTICK_XPAD.

Xpad can be compiled without LED support so this dependancy is
incorrect. JOYSTICK_XPAD_LEDS has proper dependancy on LEDS_CLASS, the
rest is Kconfig breakage.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Follow-Ups:
- Re: [patch] input: JOYSTICK_XPAD build fix
  - From: Ingo Molnar

References:
- [patch] input: JOYSTICK_XPAD build fix
  - From: Ingo Molnar

Prev by Date: Re: [patch 0/3] dynamic_printk: new feature
Next by Date: Re: Some sort corruption of my Thermal Subsystem after suspend to ram
Previous by thread: [patch] input: JOYSTICK_XPAD build fix
Next by thread: Re: [patch] input: JOYSTICK_XPAD build fix
Index(es):
- Date
- Thread