Re: [patch, -git] input: CONFIG_INPUT_APANEL build fix


* Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:

I thought the many years old rule for Linux kernel is to fix the
issues properly and not turn kernel into patchwork of crappy code.

correct, except if that would mean breakage for users.

If we want to fix the randconfi issue I'd rather revert commit
66242f7ec531953fbc2f4040c5ffe1f1ffe6c5c9 for now (they only thing it
did was beautify menuconfig look) and wait for Kconfig to be fixed. It
is not driver's task to track through all dependencies.

yep ... just dont export our internal crappiness to testers and users.

i'm not suggesting this is your fault in any way - but nevertheless many
other subsystems have to deal with the same Kconfig issues and they
manage to limp along.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [PATCH 0/6] kill i386 and x86_64 directories
    ... I had to modify both the top-lvel Makefile and the kconfig ... did the minimal changes to make it work in the new place. ... Any breakage should be easy to trigger and easy to fix. ...
    (Linux-Kernel)
  • Re: [patch, -git] input: CONFIG_INPUT_APANEL build fix
    ... did was beautify menuconfig look) and wait for Kconfig to be fixed. ... other subsystems have to deal with the same Kconfig issues and they ... I believe I see a steady stream of breakage for leds dependencies ...
    (Linux-Kernel)
  • Ingo, no more kconfig patches
    ... Kconfig entry of JOYSTICK_XPAD. ... Xpad can be compiled without LED support so this dependancy is ... create a .config that does not build, it is driver breakage. ... This breakage with your .config is *not* caused by an input bug as you ...
    (Linux-Kernel)