Re: [PATCH 4/4] power_supply: bump EC version check that we refuse to run with in olpc_battery

On Wed, 30 Apr 2008 16:30:30 -0400
Andres Salomon <dilinger@xxxxxxxxxx> wrote:


Refuse to run with an EC < 0x44. We're playing it safe, and this is
a pretty old EC version.

Also, add a comment about why we're checking the EC version.

Sigh. Presantly, the entirety of olpc_battery.c looks very nice
in an 80-column display.


diff --git a/drivers/power/olpc_battery.c b/drivers/power/olpc_battery.c
index cb45a67..086b146 100644
--- a/drivers/power/olpc_battery.c
+++ b/drivers/power/olpc_battery.c
@@ -398,7 +398,12 @@ static int __init olpc_bat_init(void)

if (!olpc_platform_info.ecver)
return -ENXIO;
- if (olpc_platform_info.ecver < 0x43) {
+
+ /*
+ * We've seen a number of EC protocol changes; this driver requires
+ * the latest EC protocol, supported by 0x44 and above.
+ */
+ if (olpc_platform_info.ecver < 0x44) {
printk(KERN_NOTICE "OLPC EC version 0x%02x too old for battery driver.\n", olpc_platform_info.ecver);
return -ENXIO;

Now it needs 0x80 :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages