Re: LogFS merge

On Fri, 2 May 2008 18:52:21 +0200, Arnd Bergmann wrote:

There are still a few i's and t's left to dot and cross:

* the changeset comments needs a Signed-off-by: line

Doh! When sending patches that happens automatically. I should teach
git the same trick.

* The MAINTAINERS file should list your name and logfs mailing list

Definitely.

* you have a few instances of '#if LINUX_VERSION_CODE >
KERNEL_VERSION(2, 6, 23)', that should go away for the merge

Yes. I would like to keep the merge version roughly in sync with the
external patch, at least for a while. Not sure how to deal with one
needing the multi-version hackery and the other not wanting it.

* The copyright notice says 2005-2007, it should probably be 2005-2008

On most files, yes.

* You may want to add a Documentation/filesystems/logfs.txt file explaining
the supported mount options.

Sure. I don't have any logfs-specific ones yet, but even that fact
should be made explicit.

* CONFIG_LOGFS should be tristate, not bool. Unfortunately, you are still
using three symbols that are not exported: swapper_space (through
BUG_ON(!page_mapping(page)->a_ops->set_page_dirty)), add_to_page_cache_lru
and inode_lock. Not sure what to do about this.

inode_lock will get fixed. The BUG_ON could get removed. Not sure
about add_to_page_cache_lru yet.

* You should really make sure the version you check in compiles,
fs/logfs/logfs.h is missing an #endif. ;-)

Making a merge dash whilst moving is not always the wisest choice. ;)

Otherwise, I don't see any reasons why logfs shouldn't go in. The code is
clean, feature-complete, and there is demand for it. The main question
I can still see is the timing with the merge window. It's almost closed,
so if logfs doesn't go in really soon, it should probably wait for the
2.6.27 window.

2.6.27 appears to make more sense, yes.

This patch fixes some of the problems mentined above.

Excellent! Thanks a bunch!

+L: logfs@xxxxxxxxx

I believe it is currently subscribers-only with the usual bounces
everyone holds so dear. I should change that and add a spam filter to
make it bearable.

Jörn

--
The only real mistake is the one from which we learn nothing.
-- John Powell
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [git pull] x86 changes for v2.6.27
    ... Please pull the latest x86 git tree from: ... There is also a _ton_ of build fixes which could have been easily ... window to squash patches is small in an append-only setup. ...
    (Linux-Kernel)
  • Re: Global Interface Table Problem.
    ... post that when I create GIT and other interfaces in the primary thread of ... close this window and move on to the window created by the primary ... thread using File -> New or CTRL N. in this second window GIT world ... But if I create pointers in B, close the B window and record in A. ...
    (microsoft.public.vc.atl)
  • Re: Diagnosing inoperative power window
    ... The left side rear seat window on my 99 Intrepid ... Just tried your trick. ... :> Is there a way to apply power directly to the motor to determine if it ... You will need to pull the door ...
    (rec.autos.makers.chrysler)
  • Re: Re: Sizing internet windows
    ... to manually resize the IE window by dragging. ... I have used another trick I picked up on another forum: ...
    (microsoft.public.windowsxp.basics)
  • Re: Tasks and Errors box wont hide automatically
    ... Ted Zieglar wrote: ... annoyance for me as well. ... The trick is to click on the Hide button before ... the window closes by itself. ...
    (microsoft.public.windows.inetexplorer.ie6_outlookexpress)