Re: [PATCH 08 of 11] anon-vma-rwsem



On Wed, 7 May 2008, Christoph Lameter wrote:

(That said, we're not running out of vm flags yet, and if we were, we
could just add another word. We're already wasting that space right now on
64-bit by calling it "unsigned long").

We sure have enough flags.

Oh, btw, I was wrong - we wouldn't want to mark the vma's (they are
unique), we need to mark the address spaces/anonvma's. So the flag would
need to be in the "struct anon_vma" (and struct address_space), not in the
vma itself. My bad. So the flag wouldn't be one of the VM_xyzzy flags, and
would require adding a new field to "struct anon_vma()"

And related to that brain-fart of mine, that obviously also means that
yes, the locking has to be stronger than "mm->mmap_sem" held for writing,
so yeah, it would have be a separate global spinlock (or perhaps a
blocking lock if you have some reason to protect anything else with this
too).

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Databases Sync Question
    ... Log shipping is more or less similar instead it uses the sql log file .ldf ... in the second case (using flags) A, ... use Flagsto mark rows that were ... server db via an ADSL connection (over the ...
    (microsoft.public.sqlserver.replication)
  • flags in For Follow Up?
    ... I am using Outlook 2003 and would like to know if I can change the order of ... the flags for Follow Up. ... I like to mark my most important messages red, ... anal-retentive list maker asking too much? ...
    (microsoft.public.outlook.general)
  • Re: Cyclone Flags
    ... and the original instructions which will go out with my kit. ... The instructions show the location of 11 of the 17 flags, ... If it turns out that Mark does not want to do them, ...
    (rec.games.pinball)
  • Re: Cyclone Flags
    ... sold them, but I dont see them available anywhere now. ... flags in a set. ... Of actual printable images, I only appear to have 10 ... I hope Mark produces them soon... ...
    (rec.games.pinball)
  • Re: No more bits in vm_area_structs vm_flags.
    ... and maybe a patch will be ugly. ... How about addding this check? ... And not calling vma_mergeat madvice. ... But what if more flags going into vm_hints in future? ...
    (Linux-Kernel)